Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Web crawler name consistency #202738

Merged
merged 8 commits into from
Dec 5, 2024
Merged

[Search] Web crawler name consistency #202738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4c6b2a
Web Crawlers instad of Web crawlers in the main navigation
JoseLuisGJ Dec 3, 2024
44ed574
Source code button in a new tab
JoseLuisGJ Dec 3, 2024
97832e6
Using Web Crawlers instad of Web crawlers in ES3
JoseLuisGJ Dec 3, 2024
5ecf1af
Opening Web Crawler repo in a new tab
JoseLuisGJ Dec 3, 2024
a6424a1
Fixing documentation link
JoseLuisGJ Dec 3, 2024
3b40e0f
Fixing classic_navigation test
JoseLuisGJ Dec 4, 2024
74d7dbd
Fixing tests
JoseLuisGJ Dec 4, 2024
b67ca8c
Elastic Web Crawler instad of Elasticsearch web crawler
JoseLuisGJ Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...search/public/applications/enterprise_search_content/components/connectors/connectors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const connectorsBreadcrumbs = [

export const crawlersBreadcrumbs = [
i18n.translate('xpack.enterpriseSearch.content.crawlers.breadcrumb', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
}),
];

Expand Down Expand Up @@ -93,7 +93,7 @@ export const Connectors: React.FC<ConnectorsProps> = ({ isCrawler }) => {
defaultMessage: 'Elasticsearch connectors',
})
: i18n.translate('xpack.enterpriseSearch.crawlers.title', {
defaultMessage: 'Elasticsearch web crawlers',
defaultMessage: 'Elastic Web Crawler',
}),
rightSideGroupProps: {
gutterSize: 's',
Expand Down
1 change: 1 addition & 0 deletions ...blic/applications/enterprise_search_content/components/connectors/crawler_empty_state.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export const CrawlerEmptyState: React.FC = () => {
fill
iconType={GithubIcon}
href={'https://github.com/elastic/crawler'}
target="_blank"
>
{i18n.translate(
'xpack.enterpriseSearch.crawlerEmptyState.openSourceCrawlerButtonLabel',
Expand Down
2 changes: 1 addition & 1 deletion ...applications/enterprise_search_content/components/new_index/new_search_index_template.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export const NewSearchIndexTemplate: React.FC<Props> = ({
{i18n.translate(
'xpack.enterpriseSearch.content.newIndex.newSearchIndexTemplate.learnMoreCrawler.linkText',
{
defaultMessage: 'Learn more about the Elastic web crawler',
defaultMessage: 'Learn more about the Elastic Web Crawler',
}
)}
</EuiLink>
Expand Down
2 changes: 1 addition & 1 deletion ...k/plugins/enterprise_search/public/applications/shared/layout/classic_nav_helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('generateSideNavItems', () => {
},
'enterpriseSearchContent:webCrawlers': {
id: 'enterpriseSearchContent:webCrawlers',
title: 'Web crawlers',
title: 'Web Crawlers',
url: '/app/enterprise_search/content/crawlers',
},
} as unknown as Record<string, ChromeNavLink | undefined>;
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/enterprise_search/public/applications/shared/layout/nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const baseNavItems = [
href: '/app/enterprise_search/content/crawlers',
id: 'crawlers',
items: undefined,
name: 'Web crawlers',
name: 'Web Crawlers',
},
],
name: 'Content',
Expand Down Expand Up @@ -184,7 +184,7 @@ const mockNavLinks = [
},
{
id: 'enterpriseSearchContent:webCrawlers',
title: 'Web crawlers',
title: 'Web Crawlers',
url: '/app/enterprise_search/content/crawlers',
},
{
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/enterprise_search/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ const contentLinks: AppDeepLink[] = [
id: 'webCrawlers',
path: `/${CRAWLERS_PATH}`,
title: i18n.translate('xpack.enterpriseSearch.navigation.contentWebcrawlersLinkLabel', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
}),
},
];
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/search_solution/search_navigation/public/classic_navigation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('classicNavigationFactory', function () {
},
{
id: 'enterpriseSearchContent:webCrawlers',
title: 'Web crawlers',
title: 'Web Crawlers',
url: '/app/enterprise_search/content/crawlers',
},
];
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/serverless_search/common/i18n_string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const CONNECTOR_LABEL: string = i18n.translate('xpack.serverlessSearch.co
export const WEB_CRAWLERS_LABEL: string = i18n.translate(
'xpack.serverlessSearch.webCrawlersLabel',
{
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
}
);

Expand Down
1 change: 1 addition & 0 deletions ...erverless_search/public/application/components/web_crawlers/empty_web_crawlers_prompt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ export const EmptyWebCrawlersPrompt: React.FC = () => {
fill
iconType={githubIcon}
href={'https://github.com/elastic/crawler'}
target="_blank"
>
{i18n.translate('xpack.serverlessSearch.webCrawlersEmpty.selfManagedButton', {
defaultMessage: 'Self-managed web crawler',
Expand Down
2 changes: 1 addition & 1 deletion .../plugins/serverless_search/public/application/components/web_crawlers_elastic_managed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const WebCrawlersElasticManaged = () => {
<EuiPageTemplate offset={0} grow restrictWidth data-test-subj="svlSearchConnectorsPage">
<EuiPageTemplate.Header
pageTitle={i18n.translate('xpack.serverlessSearch.webcrawlers.title', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
})}
data-test-subj="serverlessSearchConnectorsTitle"
restrictWidth
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/serverless_search/public/application/components/web_crawlers_overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const WebCrawlersOverview = () => {
<EuiPageTemplate offset={0} grow restrictWidth data-test-subj="svlSearchConnectorsPage">
<EuiPageTemplate.Header
pageTitle={i18n.translate('xpack.serverlessSearch.webcrawlers.title', {
defaultMessage: 'Web crawlers',
defaultMessage: 'Web Crawlers',
})}
data-test-subj="serverlessSearchConnectorsTitle"
restrictWidth
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional_search/tests/classic_navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function searchSolutionNavigation({
{ id: 'Content', label: 'Content' },
{ id: 'Indices', label: 'Indices' },
{ id: 'Connectors', label: 'Connectors' },
{ id: 'Crawlers', label: 'Web crawlers' },
{ id: 'Crawlers', label: 'Web Crawlers' },
{ id: 'Build', label: 'Build' },
{ id: 'Playground', label: 'Playground' },
{ id: 'SearchApplications', label: 'Search Applications' },
Expand Down Expand Up @@ -76,7 +76,7 @@ export default function searchSolutionNavigation({
await searchClassicNavigation.clickNavItem('Crawlers');
await searchClassicNavigation.expectNavItemActive('Crawlers');
await searchClassicNavigation.breadcrumbs.expectBreadcrumbExists('Content');
await searchClassicNavigation.breadcrumbs.expectBreadcrumbExists('Web crawlers');
await searchClassicNavigation.breadcrumbs.expectBreadcrumbExists('Web Crawlers');

// Check Build
// > Playground
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional_search/tests/solution_navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default function searchSolutionNavigation({
await solutionNavigation.sidenav.expectLinkExists({ text: 'Dashboards' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Indices' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Connectors' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web Crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Playground' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Search applications' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Behavioral Analytics' });
Expand Down Expand Up @@ -147,7 +147,7 @@ export default function searchSolutionNavigation({
deepLinkId: 'enterpriseSearchContent:webCrawlers',
});
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Content' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Web crawlers' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Web Crawlers' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({
deepLinkId: 'enterpriseSearchContent:webCrawlers',
});
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test_serverless/functional/test_suites/search/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await solutionNavigation.sidenav.expectLinkExists({ text: 'Data' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Index Management' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Connectors' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Web Crawlers' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Build' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Dev Tools' });
await solutionNavigation.sidenav.expectLinkExists({ text: 'Playground' });
Expand Down
Loading