Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ent Search Deprecation] Update enterprise_search URLs to elasticsearch for elasticsearch->content #202838

Conversation

saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Dec 3, 2024

This PR resolves this issue. In this PR, we changed the following Urls by replacing 'enterprise_search' with 'elasticsearch'.

Old URL New URL
app/enterprise_search/overview app/elasticsearch/overview
app/enterprise_search/content/search_indices app/elasticsearch/content/search_indices
app/enterprise_search/content/connectors app/elasticsearch/content/connectors
app/enterprise_search/content/crawlers app/elasticsearch/content/crawlers

@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner December 3, 2024 23:24
@saikatsarkar056 saikatsarkar056 marked this pull request as draft December 3, 2024 23:24
@saikatsarkar056 saikatsarkar056 self-assigned this Dec 3, 2024
@saikatsarkar056 saikatsarkar056 added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.18.0 v9.0.0 labels Dec 3, 2024
@saikatsarkar056 saikatsarkar056 force-pushed the change_url_for_elasticsearch_content branch from ab548a6 to 8c03de0 Compare December 5, 2024 18:11
@saikatsarkar056 saikatsarkar056 changed the title Update enterprise_search URLs to elasticsearchfor elasticsearch->content [Ent Search Deprecation] Update enterprise_search URLs to elasticsearchfor elasticsearch->content Dec 5, 2024
@saikatsarkar056 saikatsarkar056 marked this pull request as ready for review December 5, 2024 19:06
@saikatsarkar056 saikatsarkar056 requested review from a team as code owners December 5, 2024 19:06
@saikatsarkar056 saikatsarkar056 changed the title [Ent Search Deprecation] Update enterprise_search URLs to elasticsearchfor elasticsearch->content [Ent Search Deprecation] Update enterprise_search URLs to elasticsearch for elasticsearch->content Dec 5, 2024
@saikatsarkar056 saikatsarkar056 force-pushed the change_url_for_elasticsearch_content branch from b487880 to c985f85 Compare December 5, 2024 23:22
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/test/functional/config.base.js changes LGTM

@saikatsarkar056 saikatsarkar056 force-pushed the change_url_for_elasticsearch_content branch from c985f85 to 240a133 Compare December 9, 2024 17:15
@saikatsarkar056
Copy link
Contributor Author

@elasticmachine merge upstream

@saikatsarkar056 saikatsarkar056 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 9, 2024
@saikatsarkar056
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 52.3KB 52.3KB -8.0B

History

cc @saikatsarkar056

@saikatsarkar056 saikatsarkar056 removed the request for review from sphilipse December 10, 2024 20:39
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed src/plugins/navigation/common/constants.ts under SharedUX

@saikatsarkar056 saikatsarkar056 enabled auto-merge (squash) December 10, 2024 21:16
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeowner changes lgtm

@saikatsarkar056 saikatsarkar056 merged commit c5e8b7e into elastic:main Dec 11, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12270304289

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Search] Web crawler name consistency (#202738)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202838

Questions ?

Please refer to the Backport tool documentation

@saikatsarkar056
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…ch for elasticsearch->content (elastic#202838)

This PR resolves this
[issue](elastic/search-team#7961). In this PR,
we changed the following Urls by replacing 'enterprise_search' with
'elasticsearch'.

| Old URL | New URL |
| :------------------------------------- |
:------------------------------------- |
| app/enterprise_search/overview | app/elasticsearch/overview | 
| app/enterprise_search/content/search_indices |
app/elasticsearch/content/search_indices |
| app/enterprise_search/content/connectors |
app/elasticsearch/content/connectors |​
| app/enterprise_search/content/crawlers |
app/elasticsearch/content/crawlers |

---------

Co-authored-by: Elastic Machine <[email protected]>
saikatsarkar056 added a commit that referenced this pull request Dec 12, 2024
…icsearch for elasticsearch->content (#202838) (#203890)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Ent Search Deprecation] Update enterprise_search URLs to
elasticsearch for elasticsearch->content
(#202838)](#202838)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Saikat
Sarkar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T05:30:55Z","message":"[Ent
Search Deprecation] Update enterprise_search URLs to elasticsearch for
elasticsearch->content (#202838)\n\nThis PR resolves
this\r\n[issue](elastic/search-team#7961). In
this PR,\r\nwe changed the following Urls by replacing
'enterprise_search' with\r\n'elasticsearch'.\r\n\r\n| Old URL | New URL
|\r\n| :-------------------------------------
|\r\n:------------------------------------- |\r\n|
app/enterprise_search/overview | app/elasticsearch/overview | \r\n|
app/enterprise_search/content/search_indices
|\r\napp/elasticsearch/content/search_indices |\r\n|
app/enterprise_search/content/connectors
|\r\napp/elasticsearch/content/connectors |​\r\n|
app/enterprise_search/content/crawlers
|\r\napp/elasticsearch/content/crawlers
|\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"c5e8b7e72293d3fc6e39e603045b42afdfba8cc6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:EnterpriseSearch","backport:prev-minor","v8.18.0"],"number":202838,"url":"https://github.com/elastic/kibana/pull/202838","mergeCommit":{"message":"[Ent
Search Deprecation] Update enterprise_search URLs to elasticsearch for
elasticsearch->content (#202838)\n\nThis PR resolves
this\r\n[issue](elastic/search-team#7961). In
this PR,\r\nwe changed the following Urls by replacing
'enterprise_search' with\r\n'elasticsearch'.\r\n\r\n| Old URL | New URL
|\r\n| :-------------------------------------
|\r\n:------------------------------------- |\r\n|
app/enterprise_search/overview | app/elasticsearch/overview | \r\n|
app/enterprise_search/content/search_indices
|\r\napp/elasticsearch/content/search_indices |\r\n|
app/enterprise_search/content/connectors
|\r\napp/elasticsearch/content/connectors |​\r\n|
app/enterprise_search/content/crawlers
|\r\napp/elasticsearch/content/crawlers
|\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"c5e8b7e72293d3fc6e39e603045b42afdfba8cc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202838","number":202838,"mergeCommit":{"message":"[Ent
Search Deprecation] Update enterprise_search URLs to elasticsearch for
elasticsearch->content (#202838)\n\nThis PR resolves
this\r\n[issue](elastic/search-team#7961). In
this PR,\r\nwe changed the following Urls by replacing
'enterprise_search' with\r\n'elasticsearch'.\r\n\r\n| Old URL | New URL
|\r\n| :-------------------------------------
|\r\n:------------------------------------- |\r\n|
app/enterprise_search/overview | app/elasticsearch/overview | \r\n|
app/enterprise_search/content/search_indices
|\r\napp/elasticsearch/content/search_indices |\r\n|
app/enterprise_search/content/connectors
|\r\napp/elasticsearch/content/connectors |​\r\n|
app/enterprise_search/content/crawlers
|\r\napp/elasticsearch/content/crawlers
|\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"c5e8b7e72293d3fc6e39e603045b42afdfba8cc6"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants