[Obs AI Assistant] Update AI Assistant icon for Serverless #202861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viduni94
added
release_note:skip
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
viduni94
force-pushed
the
change-ai-assistant-icon-in-serverless
branch
from
f68c590 to
fb3eed1
Compare
viduni94
added
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/oblt-deploy |
afharo
reviewed
Dec 4, 2024
| @@ -111,6 +111,7 @@ export class ObservabilityAIAssistantAppPlugin | |||
| appService={appService} | |||
| coreStart={coreStart} | |||
| pluginsStart={pluginsStart} | |||
| isServerless={!!pluginsStart.serverless} | |||
There was a problem hiding this comment.
no need to depend on the serverless plugin to perform this check. The constructor of the plugin has the buildFlavor:
constructor(initContext: PluginInitializerContext) {
const isServerless = initContext.env.packageInfo.buildFlavor === 'serverless';
}
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @viduni94 |
|
Deployed serverless cluster from PR: https://serverless-bnhdu-e9f876.kb.eu-west-1.aws.qa.elastic.cloud/app/management |
neptunian
approved these changes
Dec 4, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8a73528)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
…2861) (#203094) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Update AI Assistant icon for Serverless (#202861)](#202861) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T12:38:33Z","message":"[Obs AI Assistant] Update AI Assistant icon for Serverless (#202861)\n\n## Summary\r\n\r\n### Problem\r\nThe Obs AI Assistant icon doesn't look as expected in serverless top\r\nnavigation.\r\n\r\n### Solution\r\nUpdate button CSS for Obs AI Assistant top nav icon for serverless. No\r\nchanges to the classic navigation.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8a73528ab10acb5e10d86ac9e60a3a42d1e11f89","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0"],"title":"[Obs AI Assistant] Update AI Assistant icon for Serverless","number":202861,"url":"https://github.com/elastic/kibana/pull/202861","mergeCommit":{"message":"[Obs AI Assistant] Update AI Assistant icon for Serverless (#202861)\n\n## Summary\r\n\r\n### Problem\r\nThe Obs AI Assistant icon doesn't look as expected in serverless top\r\nnavigation.\r\n\r\n### Solution\r\nUpdate button CSS for Obs AI Assistant top nav icon for serverless. No\r\nchanges to the classic navigation.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8a73528ab10acb5e10d86ac9e60a3a42d1e11f89"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202861","number":202861,"mergeCommit":{"message":"[Obs AI Assistant] Update AI Assistant icon for Serverless (#202861)\n\n## Summary\r\n\r\n### Problem\r\nThe Obs AI Assistant icon doesn't look as expected in serverless top\r\nnavigation.\r\n\r\n### Solution\r\nUpdate button CSS for Obs AI Assistant top nav icon for serverless. No\r\nchanges to the classic navigation.\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8a73528ab10acb5e10d86ac9e60a3a42d1e11f89"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…02861) ## Summary ### Problem The Obs AI Assistant icon doesn't look as expected in serverless top navigation. ### Solution Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The Obs AI Assistant icon doesn't look as expected in serverless top navigation.
Solution
Update button CSS for Obs AI Assistant top nav icon for serverless. No changes to the classic navigation.
Screenshots
Serverless light mode::
Serverless dark mode:
Classic navigation (non-serverless):
Checklist
release_note:*label is applied per the guidelines