[SecuritySolution][Onboarding] Siem migration start card and flyout - Part 1 #202886
+2,194
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ui' into 10667/siem_migrations/onboarding_ui_flyout
…grations/onboarding_ui_flyout
…ns/onboarding_ui_flyout
semd
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
semd
changed the title
e40pud
reviewed
Dec 5, 2024
x-pack/plugins/security_solution/common/siem_migrations/model/common.gen.ts
Outdated
Show resolved
Hide resolved
e40pud
approved these changes
Dec 5, 2024
...les/components/data_input_flyout/steps/rules/sub_steps/rules_file_upload/parse_rules_file.ts
Outdated
Show resolved
Hide resolved
e40pud
approved these changes
Dec 5, 2024
angorayc
approved these changes
Dec 5, 2024
| @@ -686,7 +687,7 @@ If a record already exists for the specified entity, that record is overwritten | |||
| this.log.info(`${new Date().toISOString()} Calling API CreateRuleMigration`); | |||
| return this.kbnClient | |||
| .request<CreateRuleMigrationResponse>({ | |||
| path: '/internal/siem_migrations/rules', | |||
| path: replaceParams('/internal/siem_migrations/rules/{migration_id}', props.params), | |||
There was a problem hiding this comment.
From the type perspective, props.params.migration_id could be undefined. Is this an actual case?
There was a problem hiding this comment.
This is auto-generated code from the API schema. But yes, I checked the props.params type here is:
{ migration_id?: string | undefined; }.
| ...(isDarkMode && { backgroundColor: euiTheme.colors.lightestShade }), | ||
| }} | ||
| > | ||
| <OnboardingCardContentPanel> | ||
| {canExecuteConnectors ? ( |
There was a problem hiding this comment.
nit: It has a quick flash showing MissingPrivilegesCallOut when checkCompleteMetadata is not available yet.
Screen.Recording.2024-12-05.at.14.59.50.mov
There was a problem hiding this comment.
Yup, good catch. I'll address that in the following PR 👍
There was a problem hiding this comment.
cc: @agusruidiazgd This might also happen in the assistant card
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
cc @semd |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b5c1194)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
…yout - Part 1 (#202886) (#203141) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution][Onboarding] Siem migration start card and flyout - Part 1 (#202886)](#202886) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:29:51Z","message":"[SecuritySolution][Onboarding] Siem migration start card and flyout - Part 1 (#202886)\n\n## Summary\r\n\r\nPart of: https://github.com/elastic/security-team/issues/10667\r\n\r\nImplementation of the Onboarding card to create migrations using the\r\nflyout\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work. Otherwise only the default topic will be available and the\r\ntopic selector won't be displayed.\r\n\r\n<img width=\"1547\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24\">\r\n\r\n#### To do in part 2:\r\n- Complete implementation of migration finished panel: chart and stats\r\n- Improve implementation of migration ready panel: should only allow\r\nopen the flyout\r\n- Implement missing steps in the flyout: Macros and Lookups\r\n\r\n### Test \r\nEnable experimental flag\r\nUse file:\r\n[1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b5c119496ace2c56da6752c7e9ab26ef963fec95","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0"],"title":"[SecuritySolution][Onboarding] Siem migration start card and flyout - Part 1","number":202886,"url":"https://github.com/elastic/kibana/pull/202886","mergeCommit":{"message":"[SecuritySolution][Onboarding] Siem migration start card and flyout - Part 1 (#202886)\n\n## Summary\r\n\r\nPart of: https://github.com/elastic/security-team/issues/10667\r\n\r\nImplementation of the Onboarding card to create migrations using the\r\nflyout\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work. Otherwise only the default topic will be available and the\r\ntopic selector won't be displayed.\r\n\r\n<img width=\"1547\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24\">\r\n\r\n#### To do in part 2:\r\n- Complete implementation of migration finished panel: chart and stats\r\n- Improve implementation of migration ready panel: should only allow\r\nopen the flyout\r\n- Implement missing steps in the flyout: Macros and Lookups\r\n\r\n### Test \r\nEnable experimental flag\r\nUse file:\r\n[1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b5c119496ace2c56da6752c7e9ab26ef963fec95"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202886","number":202886,"mergeCommit":{"message":"[SecuritySolution][Onboarding] Siem migration start card and flyout - Part 1 (#202886)\n\n## Summary\r\n\r\nPart of: https://github.com/elastic/security-team/issues/10667\r\n\r\nImplementation of the Onboarding card to create migrations using the\r\nflyout\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work. Otherwise only the default topic will be available and the\r\ntopic selector won't be displayed.\r\n\r\n<img width=\"1547\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24\">\r\n\r\n#### To do in part 2:\r\n- Complete implementation of migration finished panel: chart and stats\r\n- Improve implementation of migration ready panel: should only allow\r\nopen the flyout\r\n- Implement missing steps in the flyout: Macros and Lookups\r\n\r\n### Test \r\nEnable experimental flag\r\nUse file:\r\n[1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b5c119496ace2c56da6752c7e9ab26ef963fec95"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of: https://github.com/elastic/security-team/issues/10667
Implementation of the Onboarding card to create migrations using the flyout
Note
This feature needs
siemMigrationsEnabledexperimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed.To do in part 2:
Test
Enable experimental flag
Use file: 1733135547_1420.json