Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Ensure that old indices are detected for reindexing #203082

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Dec 5, 2024

Summary

We need to handle the following response shape from GET _migration/deprecations

    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
Screenshot 2024-12-05 at 12 44 59

To reviewers

These changes were developed/tested on 8.x and must be backported.

Related

@jloleysens jloleysens added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v9.0.0 backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Dec 5, 2024
@jloleysens jloleysens requested a review from a team as a code owner December 5, 2024 11:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / StatusFilter should render

Metrics [docs]

✅ unchanged

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks @jloleysens!

@jloleysens jloleysens merged commit 3579425 into elastic:main Dec 5, 2024
23 checks passed
@jloleysens jloleysens deleted the ua/temp-fix-handle-deprecated-index-response branch December 5, 2024 14:47
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12182134279

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">

## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062

(cherry picked from commit 3579425)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">

## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062

(cherry picked from commit 3579425)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 5, 2024
…) (#203119)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[UA] Ensure that old indices are detected for reindexing
(#203082)](#203082)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T14:47:32Z","message":"[UA]
Ensure that old indices are detected for reindexing (#203082)\n\n##
Summary\r\n\r\nWe need to handle the following response shape from
`GET\r\n_migration/deprecations`\r\n\r\n```jsonc\r\n \"myindex\": [\r\n
{\r\n \"level\": \"critical\",\r\n \"message\": \"Old index with a
compatibility version < 8.0\", // specifically this message\r\n \"url\":
\"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html\",\r\n
\"details\": \"This index has version: 7.17.25\",\r\n
\"resolve_during_rolling_upgrade\": false\r\n }\r\n ]\r\n```\r\n\r\n<img
width=\"1142\" alt=\"Screenshot 2024-12-05 at 12 44
59\"\r\nsrc=\"https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b\">\r\n\r\n\r\n##
To reviewers\r\n\r\nThese changes were developed/tested on `8.x` and
must be backported.\r\n\r\nRelated\r\n*
https://github.com/elastic/kibana/issues/202669\r\n*
https://github.com/elastic/elasticsearch/issues/118062","sha":"3579425d77caeb59bdb101a2f3c88fe111f8e65e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade
Assistant","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[UA]
Ensure that old indices are detected for
reindexing","number":203082,"url":"https://github.com/elastic/kibana/pull/203082","mergeCommit":{"message":"[UA]
Ensure that old indices are detected for reindexing (#203082)\n\n##
Summary\r\n\r\nWe need to handle the following response shape from
`GET\r\n_migration/deprecations`\r\n\r\n```jsonc\r\n \"myindex\": [\r\n
{\r\n \"level\": \"critical\",\r\n \"message\": \"Old index with a
compatibility version < 8.0\", // specifically this message\r\n \"url\":
\"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html\",\r\n
\"details\": \"This index has version: 7.17.25\",\r\n
\"resolve_during_rolling_upgrade\": false\r\n }\r\n ]\r\n```\r\n\r\n<img
width=\"1142\" alt=\"Screenshot 2024-12-05 at 12 44
59\"\r\nsrc=\"https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b\">\r\n\r\n\r\n##
To reviewers\r\n\r\nThese changes were developed/tested on `8.x` and
must be backported.\r\n\r\nRelated\r\n*
https://github.com/elastic/kibana/issues/202669\r\n*
https://github.com/elastic/elasticsearch/issues/118062","sha":"3579425d77caeb59bdb101a2f3c88fe111f8e65e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203082","number":203082,"mergeCommit":{"message":"[UA]
Ensure that old indices are detected for reindexing (#203082)\n\n##
Summary\r\n\r\nWe need to handle the following response shape from
`GET\r\n_migration/deprecations`\r\n\r\n```jsonc\r\n \"myindex\": [\r\n
{\r\n \"level\": \"critical\",\r\n \"message\": \"Old index with a
compatibility version < 8.0\", // specifically this message\r\n \"url\":
\"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html\",\r\n
\"details\": \"This index has version: 7.17.25\",\r\n
\"resolve_during_rolling_upgrade\": false\r\n }\r\n ]\r\n```\r\n\r\n<img
width=\"1142\" alt=\"Screenshot 2024-12-05 at 12 44
59\"\r\nsrc=\"https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b\">\r\n\r\n\r\n##
To reviewers\r\n\r\nThese changes were developed/tested on `8.x` and
must be backported.\r\n\r\nRelated\r\n*
https://github.com/elastic/kibana/issues/202669\r\n*
https://github.com/elastic/elasticsearch/issues/118062","sha":"3579425d77caeb59bdb101a2f3c88fe111f8e65e"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 5, 2024
) (#203118)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[UA] Ensure that old indices are detected for reindexing
(#203082)](#203082)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T14:47:32Z","message":"[UA]
Ensure that old indices are detected for reindexing (#203082)\n\n##
Summary\r\n\r\nWe need to handle the following response shape from
`GET\r\n_migration/deprecations`\r\n\r\n```jsonc\r\n \"myindex\": [\r\n
{\r\n \"level\": \"critical\",\r\n \"message\": \"Old index with a
compatibility version < 8.0\", // specifically this message\r\n \"url\":
\"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html\",\r\n
\"details\": \"This index has version: 7.17.25\",\r\n
\"resolve_during_rolling_upgrade\": false\r\n }\r\n ]\r\n```\r\n\r\n<img
width=\"1142\" alt=\"Screenshot 2024-12-05 at 12 44
59\"\r\nsrc=\"https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b\">\r\n\r\n\r\n##
To reviewers\r\n\r\nThese changes were developed/tested on `8.x` and
must be backported.\r\n\r\nRelated\r\n*
https://github.com/elastic/kibana/issues/202669\r\n*
https://github.com/elastic/elasticsearch/issues/118062","sha":"3579425d77caeb59bdb101a2f3c88fe111f8e65e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade
Assistant","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[UA]
Ensure that old indices are detected for
reindexing","number":203082,"url":"https://github.com/elastic/kibana/pull/203082","mergeCommit":{"message":"[UA]
Ensure that old indices are detected for reindexing (#203082)\n\n##
Summary\r\n\r\nWe need to handle the following response shape from
`GET\r\n_migration/deprecations`\r\n\r\n```jsonc\r\n \"myindex\": [\r\n
{\r\n \"level\": \"critical\",\r\n \"message\": \"Old index with a
compatibility version < 8.0\", // specifically this message\r\n \"url\":
\"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html\",\r\n
\"details\": \"This index has version: 7.17.25\",\r\n
\"resolve_during_rolling_upgrade\": false\r\n }\r\n ]\r\n```\r\n\r\n<img
width=\"1142\" alt=\"Screenshot 2024-12-05 at 12 44
59\"\r\nsrc=\"https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b\">\r\n\r\n\r\n##
To reviewers\r\n\r\nThese changes were developed/tested on `8.x` and
must be backported.\r\n\r\nRelated\r\n*
https://github.com/elastic/kibana/issues/202669\r\n*
https://github.com/elastic/elasticsearch/issues/118062","sha":"3579425d77caeb59bdb101a2f3c88fe111f8e65e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203082","number":203082,"mergeCommit":{"message":"[UA]
Ensure that old indices are detected for reindexing (#203082)\n\n##
Summary\r\n\r\nWe need to handle the following response shape from
`GET\r\n_migration/deprecations`\r\n\r\n```jsonc\r\n \"myindex\": [\r\n
{\r\n \"level\": \"critical\",\r\n \"message\": \"Old index with a
compatibility version < 8.0\", // specifically this message\r\n \"url\":
\"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html\",\r\n
\"details\": \"This index has version: 7.17.25\",\r\n
\"resolve_during_rolling_upgrade\": false\r\n }\r\n ]\r\n```\r\n\r\n<img
width=\"1142\" alt=\"Screenshot 2024-12-05 at 12 44
59\"\r\nsrc=\"https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b\">\r\n\r\n\r\n##
To reviewers\r\n\r\nThese changes were developed/tested on `8.x` and
must be backported.\r\n\r\nRelated\r\n*
https://github.com/elastic/kibana/issues/202669\r\n*
https://github.com/elastic/elasticsearch/issues/118062","sha":"3579425d77caeb59bdb101a2f3c88fe111f8e65e"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <[email protected]>
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">


## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">


## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">


## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">


## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">


## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
)

## Summary

We need to handle the following response shape from `GET
_migration/deprecations`

```jsonc
    "myindex": [
      {
        "level": "critical",
        "message": "Old index with a compatibility version < 8.0", // specifically this message
        "url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
        "details": "This index has version: 7.17.25",
        "resolve_during_rolling_upgrade": false
      }
    ]
```

<img width="1142" alt="Screenshot 2024-12-05 at 12 44 59"
src="https://github.com/user-attachments/assets/723e19ab-dd9d-4b6a-bcda-26a5c8bffa0b">


## To reviewers

These changes were developed/tested on `8.x` and must be backported.

Related
* elastic#202669
* elastic/elasticsearch#118062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants