[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) #203134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart (cherry picked from commit f1109cf)
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Historycc @fkanout |
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
… is invalid (#203096) (#203466) # Backport This will backport the following commits from `main` to `8.15`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203134","number":203134,"state":"MERGED","mergeCommit":{"sha":"a70bdf01cd8208c0f2358a98f5fcc5d10ac0a7d6","message":"[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) (#203134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is\ninvalid (#203096)](https://github.com/elastic/kibana/pull/203096)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Faisal\nKanout\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-05T16:07:58Z\",\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"Team:obs-ux-management\"],\"title\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is\ninvalid\",\"number\":203096,\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"number\":203096,\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}}]}] BACKPORT-->\n\nCo-authored-by: Faisal Kanout <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
… is invalid (#203096) (#203468) # Backport This will backport the following commits from `main` to `8.17`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203134","number":203134,"state":"MERGED","mergeCommit":{"sha":"a70bdf01cd8208c0f2358a98f5fcc5d10ac0a7d6","message":"[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) (#203134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is\ninvalid (#203096)](https://github.com/elastic/kibana/pull/203096)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Faisal\nKanout\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-05T16:07:58Z\",\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"Team:obs-ux-management\"],\"title\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is\ninvalid\",\"number\":203096,\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"number\":203096,\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}}]}] BACKPORT-->\n\nCo-authored-by: Faisal Kanout <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
… is invalid (#203096) (#203467) # Backport This will backport the following commits from `main` to `8.16`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203134","number":203134,"state":"MERGED","mergeCommit":{"sha":"a70bdf01cd8208c0f2358a98f5fcc5d10ac0a7d6","message":"[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) (#203134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is\ninvalid (#203096)](https://github.com/elastic/kibana/pull/203096)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Faisal\nKanout\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-05T16:07:58Z\",\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"Team:obs-ux-management\"],\"title\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is\ninvalid\",\"number\":203096,\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"number\":203096,\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}}]}] BACKPORT-->\n\nCo-authored-by: Faisal Kanout <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation