[Dataset Quality] Work around a geoip limitation in CI #203165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The geoip database is not available in CI, so a `tags` field is added to all ingested APM app log documents. This covers up the difference in field counts between serverless CI and MKI by always having a `tags` field in the documents.
weltenwort
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
…-field-limit-mitigation-test-on-mki
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
cc @weltenwort |
awahab07
approved these changes
Dec 9, 2024
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Dec 11, 2024
The geoip database is not available in CI, so a `tags` field is added to all ingested APM app log documents. This covers up the difference in field counts between serverless CI and MKI by always having a `tags` field in the documents. It also unskips the test that failed in MKI because of this. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 62e059f) # Conflicts: # x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
weltenwort
added a commit
that referenced
this pull request
Dec 11, 2024
#203795) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Work around a geoip limitation in CI (#203165)](#203165) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T11:46:40Z","message":"[Dataset Quality] Work around a geoip limitation in CI (#203165)\n\nThe geoip database is not available in CI, so a `tags` field is added to\r\nall ingested APM app log documents. This covers up the difference in\r\nfield counts between serverless CI and MKI by always having a `tags`\r\nfield in the documents. It also unskips the test that failed in MKI\r\nbecause of this.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"62e059f0ca62f6f016af3bdb47fc74826f05f896","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","Feature:Dataset Health"],"number":203165,"url":"https://github.com/elastic/kibana/pull/203165","mergeCommit":{"message":"[Dataset Quality] Work around a geoip limitation in CI (#203165)\n\nThe geoip database is not available in CI, so a `tags` field is added to\r\nall ingested APM app log documents. This covers up the difference in\r\nfield counts between serverless CI and MKI by always having a `tags`\r\nfield in the documents. It also unskips the test that failed in MKI\r\nbecause of this.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"62e059f0ca62f6f016af3bdb47fc74826f05f896"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203165","number":203165,"mergeCommit":{"message":"[Dataset Quality] Work around a geoip limitation in CI (#203165)\n\nThe geoip database is not available in CI, so a `tags` field is added to\r\nall ingested APM app log documents. This covers up the difference in\r\nfield counts between serverless CI and MKI by always having a `tags`\r\nfield in the documents. It also unskips the test that failed in MKI\r\nbecause of this.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"62e059f0ca62f6f016af3bdb47fc74826f05f896"}}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
The geoip database is not available in CI, so a `tags` field is added to all ingested APM app log documents. This covers up the difference in field counts between serverless CI and MKI by always having a `tags` field in the documents. It also unskips the test that failed in MKI because of this. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The geoip database is not available in CI, so a
tagsfield is added to all ingested APM app log documents. This PR covers up the difference in field counts between serverless CI and MKI by always having atagsfield in the documents. It also unskips the test that failed in MKI because of this.x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts#202641geoipingest processor not working in serverless FTR config #203161