[Cloud Security] Added 'x-elastic-internal-origin' to agentless axios request headers for Kibana 9.0 #203188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanrathier
added
8.18 candidate
release_note:skip
seanrathier
commented
Dec 5, 2024
There was a problem hiding this comment.
I moved the error handling tests to a secluded describe section in this file.
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
cc @seanrathier |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 6, 2024
… request headers for Kibana 9.0 (elastic#203188) (cherry picked from commit e08d712)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 6, 2024
… agentless axios request headers for Kibana 9.0 (#203188) (#203332) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Added 'x-elastic-internal-origin' to agentless axios request headers for Kibana 9.0 (#203188)](#203188) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T19:21:42Z","message":"[Cloud Security] Added 'x-elastic-internal-origin' to agentless axios request headers for Kibana 9.0 (#203188)","sha":"e08d7126eb57dfa18a8607df7244a63caacc0bfc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor","8.18 candidate"],"title":"[Cloud Security] Added 'x-elastic-internal-origin' to agentless axios request headers for Kibana 9.0","number":203188,"url":"https://github.com/elastic/kibana/pull/203188","mergeCommit":{"message":"[Cloud Security] Added 'x-elastic-internal-origin' to agentless axios request headers for Kibana 9.0 (#203188)","sha":"e08d7126eb57dfa18a8607df7244a63caacc0bfc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203188","number":203188,"mergeCommit":{"message":"[Cloud Security] Added 'x-elastic-internal-origin' to agentless axios request headers for Kibana 9.0 (#203188)","sha":"e08d7126eb57dfa18a8607df7244a63caacc0bfc"}}]}] BACKPORT--> Co-authored-by: seanrathier <[email protected]>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Dec 7, 2024
… request headers for Kibana 9.0 (elastic#203188)
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
… request headers for Kibana 9.0 (elastic#203188)
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
… request headers for Kibana 9.0 (elastic#203188)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
… request headers for Kibana 9.0 (elastic#203188)
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
… request headers for Kibana 9.0 (elastic#203188)
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
… request headers for Kibana 9.0 (elastic#203188)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
… request headers for Kibana 9.0 (elastic#203188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kibana 9.0 requires all request made with
axioshave the request headerx-elastic-internal-originset toKibanato avoid appearing as an “external” integration. Any requests without it will be blocked in Kibana 9.0Checklist
Reviewers should verify this PR satisfies this list as well.