Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Refactoring the limit error message for agentless agent #203257

Merged

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Dec 6, 2024

Summary

Handling the provisioned limit was previously committed, this refactor changed the error message returned to the user in a toast message.

@seanrathier seanrathier added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 6, 2024
@seanrathier seanrathier self-assigned this Dec 6, 2024
@seanrathier seanrathier requested a review from a team as a code owner December 6, 2024 16:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@seanrathier seanrathier enabled auto-merge (squash) December 6, 2024 16:11
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@seanrathier seanrathier merged commit 1d3bf85 into elastic:main Dec 6, 2024
19 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12204828877

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 6, 2024
…ess agent (#203257) (#203330)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Refactoring the limit error message for agentless
agent (#203257)](#203257)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-06T19:20:33Z","message":"[Cloud
Security] Refactoring the limit error message for agentless agent
(#203257)","sha":"1d3bf85d19985f99d9d582ffad0353747cd5c60b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud
Security","backport:prev-minor","8.18 candidate"],"title":"[Cloud
Security] Refactoring the limit error message for agentless
agent","number":203257,"url":"https://github.com/elastic/kibana/pull/203257","mergeCommit":{"message":"[Cloud
Security] Refactoring the limit error message for agentless agent
(#203257)","sha":"1d3bf85d19985f99d9d582ffad0353747cd5c60b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203257","number":203257,"mergeCommit":{"message":"[Cloud
Security] Refactoring the limit error message for agentless agent
(#203257)","sha":"1d3bf85d19985f99d9d582ffad0353747cd5c60b"}}]}]
BACKPORT-->

Co-authored-by: seanrathier <[email protected]>
markov00 pushed a commit to markov00/kibana that referenced this pull request Dec 7, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants