[UA] Update API integration tests #203308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]
History
cc @ElenaStoeva |
rudolf
requested changes
Dec 9, 2024
| @@ -30,7 +30,6 @@ const deprecationMock = { | |||
| message: | |||
| '[types removal] Specifying include_type_name in get index template requests is deprecated.', | |||
| 'data_stream.type': 'logs', | |||
| 'data_stream.dataset': 'deprecation.elasticsearch', | |||
There was a problem hiding this comment.
To be an accurate mock we should rather change the value to elasticsearch.deprecation instead of removing the field completely
|
Superseded by #203418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203044
Summary
This PR updates the API integration tests, removing a property from the deprecation mock which causes 9.0 Es to fail with error
illegal_argument_exception: [constant_keyword] field [data_stream.dataset] only accepts values that are equal to the value defined in the mappings [elasticsearch.deprecation], but got [deprecation.elasticsearch].Upon checking the UA plugin code, I don't see any dependency on this property which should be updated - it it only used in the deprecation mock for the test.