Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Cloud Security] Refactoring the limit error message for agentless agent (#203257) #203330

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[8.x] [Cloud Security] Refactoring the limit error message for agentless agent (#203257) #203330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions x-pack/plugins/fleet/server/services/agents/agentless_agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ import { listFleetServerHosts } from '../fleet_server_host';
import type { AgentlessConfig } from '../utils/agentless';
import { prependAgentlessApiBasePathToEndpoint, isAgentlessEnabled } from '../utils/agentless';

interface AgentlessAgentErrorHandlingMessages {
[key: string]: {
[key: string]: {
log: string;
message: string;
};
};
}

class AgentlessAgentService {
public async createAgentlessAgent(
esClient: ElasticsearchClient,
Expand Down Expand Up @@ -326,14 +335,12 @@ class AgentlessAgentService {
throw this.getAgentlessAgentError(action, error.message, traceId);
}

const ERROR_HANDLING_MESSAGES = this.getErrorHandlingMessages(agentlessPolicyId);
const ERROR_HANDLING_MESSAGES: AgentlessAgentErrorHandlingMessages =
this.getErrorHandlingMessages(agentlessPolicyId);

if (error.response) {
if (error.response.status in ERROR_HANDLING_MESSAGES) {
const handledResponseErrorMessage =
ERROR_HANDLING_MESSAGES[error.response.status as keyof typeof ERROR_HANDLING_MESSAGES][
action
];
const handledResponseErrorMessage = ERROR_HANDLING_MESSAGES[error.response.status][action];
this.handleResponseError(
action,
error.response,
Expand Down Expand Up @@ -426,7 +433,7 @@ class AgentlessAgentService {
: new AgentlessAgentDeleteError(this.withRequestIdMessage(userMessage, traceId));
}

private getErrorHandlingMessages(agentlessPolicyId: string) {
private getErrorHandlingMessages(agentlessPolicyId: string): AgentlessAgentErrorHandlingMessages {
return {
400: {
create: {
Expand Down Expand Up @@ -483,13 +490,7 @@ class AgentlessAgentService {
create: {
log: '[Agentless API] Creating the agentless agent failed with a status 429 for agentless policy, agentless agent limit has been reached for this deployment or project.',
message:
'the Agentless API could not create the agentless agent, you have reached the limit of agentless agents provisioned for this deployment or project. Consider removing some agentless agents and try again or use agent-based agents for this integration.',
},
// this is likely to happen when deleting agentless agents, but covering it in case
delete: {
log: '[Agentless API] Deleting the agentless deployment failed with a status 429 for agentless policy, agentless agent limit has been reached for this deployment or project.',
message:
'the Agentless API could not delete the agentless deployment, you have reached the limit of agentless agents provisioned for this deployment or project. Consider removing some agentless agents and try again or use agent-based agents for this integration.',
'you have reached the limit for agentless provisioning. Please remove some or switch to agent-based integration.',
},
},
500: {
Expand Down
Loading