[Obs AI Assistant] Fix null pointer in function definition #203344

sorenlouv · 2024-12-06T20:25:36Z

Closes #201713

elasticmachine · 2024-12-06T20:25:42Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

github-actions · 2024-12-06T20:25:49Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

sorenlouv · 2024-12-06T20:34:56Z

...lugins/observability_solution/observability_ai_assistant_app/server/functions/query/index.ts

-            .map((fn) => [fn.name, { description: fn.description, schema: fn.parameters }])
+          [...actions, ...esqlFunctions].map((fn) => [
+            fn.name,
+            { description: fn.description, schema: fn.parameters } as ToolDefinition,


@pgayvallet @arturoliduena actions.parameters is typed as ToolSchema whereas esqlFunctions is typed as CompatibleJSONSchema. This gives some incompatibilities when merging the types so I had to do type assertion.

Is the plan to get rid of CompatibleJSONSchema in favor of ToolSchema?

CompatibleJSONSchema is defined here

Is the plan to get rid of CompatibleJSONSchema in favor of ToolSchema?

I think that question is on your side? CompatibleJSONSchema is a o11y assistant type, ToolSchema is an inference plugin's type. You're more than welcome, and encouraged, to drop your own types in favor of the inference framework's, but that's not really my call, is it?

Yes, in that case it's mostly a question for @arturoliduena

I’m also in favor of moving towards using the inference plugin’s types when possible,as it supports a more consistent approach across plugins. However, I had a similar conversation with @dgieselaar and at the moment we agree on keeping o11y assistant types:

#199286 (comment)

Ideally we encapsulate the event type from the inference client here, and convert it into ChatCompletionChunkEvent. We should eventually completely drop ChatCompletionChunkEvent in favor of the inference plugin's types, but that means that we need to make changes in many places, and there's some stuff that isn't supported yet by the Inference plugin's types. Until that happens, I think we should limit the blast radius and stick to our own types where we can - which should be everywhere except for the implementation of this function, I think.

elasticmachine · 2024-12-09T10:47:45Z

💚 Build Succeeded

Buildkite Build
Commit: 8d865c6
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203344-8d865c6dd542

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityAIAssistantApp`	237.9KB	237.9KB	+32.0B
`searchAssistant`	160.2KB	160.2KB	+32.0B
total			+64.0B

History

💔 Build #257949 failed a39c064

kibanamachine · 2024-12-09T14:00:23Z

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12237189820

…03344) Closes elastic#201713 (cherry picked from commit 1d9ca1e)

kibanamachine · 2024-12-09T14:05:44Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts
✅	8.17
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 203344

Questions ?

Please refer to the Backport tool documentation

…03344) (#203435) # Backport This will backport the following commits from `main` to `8.17`: - [[Obs AI Assistant] Fix null pointer in function definition (#203344)](#203344)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Søren Louv-Jansen <[email protected]>

…3344) (#203436) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Fix null pointer in function definition (#203344)](#203344)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Søren Louv-Jansen <[email protected]>

…03344) Closes elastic#201713

sorenlouv · 2024-12-10T13:32:16Z

💚 All backports created successfully

Status	Branch	Result
✅	8.16

Note: Successful backport PRs will be merged automatically after passing CI.