[8.x] [Automatic Import] Add datastream name as dataset value in manifest (#203106) #203383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#203106) ## Release note Use Data stream name for data_stream.dataset value in input manifests ## Summary Closes elastic#201478 This PR uses the user-supplied data stream name as the `data_stream.dataset` value instead of a generic placeholder. Custom Fleet integrations default to a generic dataset (data_stream.dataset) value - something like `http_endpoint.generic.` Since users configure their own options for a custom integration, this workflow makes sense. Elastic integrations, on the other hand, default to a predetermined naming convention based on the integration package + datastream name for dataset - something like github.issues for the issues data stream from the Github package. Hence defaulting it to `package_name.datastream_name` <img width="729" alt="Screenshot 2024-12-05 at 15 12 32" src="https://github.com/user-attachments/assets/2dad5de3-a329-403f-be46-2dbc76906b03"> <img width="868" alt="Screenshot 2024-12-05 at 15 12 16" src="https://github.com/user-attachments/assets/2959e26a-8095-4efa-bf9b-c5e953e849b9"> ### Checklist Check the PR satisfies following conditions. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit eb1c8fc)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @bhapas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation