Support incoming Preconfigured Endpoints #203473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samiul-TheSoccerFan
added
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7569[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed. |
|
@elasticmachine merge upstream |
sphilipse
reviewed
Dec 9, 2024
| const e5TypeName = await e5TypeCell.getVisibleText(); | ||
| expect(e5TypeName).to.contain('text_embedding'); | ||
| // we need at least one (ELSER) otherwise index mapping will start to fail | ||
| expect(rows.length).to.greaterThan(1); |
There was a problem hiding this comment.
Should we also check that one of the entries contains an ELSER endpoint?
| @@ -37,10 +37,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { | |||
| await pageObjects.svlCommonPage.loginWithRole('developer'); | |||
| }); | |||
|
|
|||
| after(async () => { | |||
| await ml.api.cleanMlIndices(); | |||
There was a problem hiding this comment.
question: why are we removing this?
There was a problem hiding this comment.
This was originally added as part of the cleanup process, but now it feels excessive. Since we didn’t create any ml-* indices as part of the tests, I have decided to remove that step. Do you think it’s still necessary or good to have as part of the cleanup process?
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
TattdCodeMonkey
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
does this need backported to 8.16 & 8.17 given that it's essentially just a data-test-subj id change and updating FTRs for serverless?
I don't see the harm in backporting it, just seems a little excessive. Unless we foresee backporting more changes to inference endpoints to 8.16 & 8.17
The reason for backporting is to stay safe however, we do not plan to push any more changes in Before making any final decision, I will verify with ML team and adjust the label according to that. |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
## Summary Currently, the FTR tests are written to expect only two preconfigured endpoints. However, there might be more incoming, and this PR generalizes these tests so they do not depend on the number of preconfigured endpoints in the future. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a5c9ed7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
5 tasks
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Support incoming Preconfigured Endpoints (#203473)](#203473) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T21:09:31Z","message":"Support incoming Preconfigured Endpoints (#203473)\n\n## Summary\r\n\r\nCurrently, the FTR tests are written to expect only two preconfigured\r\nendpoints. However, there might be more incoming, and this PR\r\ngeneralizes these tests so they do not depend on the number of\r\npreconfigured endpoints in the future.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a5c9ed7bb8652807e11ab6eac2979b61fa239b2c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","ci:build-serverless-image","backport:version","v8.18.0"],"title":"Support incoming Preconfigured Endpoints","number":203473,"url":"https://github.com/elastic/kibana/pull/203473","mergeCommit":{"message":"Support incoming Preconfigured Endpoints (#203473)\n\n## Summary\r\n\r\nCurrently, the FTR tests are written to expect only two preconfigured\r\nendpoints. However, there might be more incoming, and this PR\r\ngeneralizes these tests so they do not depend on the number of\r\npreconfigured endpoints in the future.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a5c9ed7bb8652807e11ab6eac2979b61fa239b2c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203473","number":203473,"mergeCommit":{"message":"Support incoming Preconfigured Endpoints (#203473)\n\n## Summary\r\n\r\nCurrently, the FTR tests are written to expect only two preconfigured\r\nendpoints. However, there might be more incoming, and this PR\r\ngeneralizes these tests so they do not depend on the number of\r\npreconfigured endpoints in the future.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a5c9ed7bb8652807e11ab6eac2979b61fa239b2c"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Currently, the FTR tests are written to expect only two preconfigured endpoints. However, there might be more incoming, and this PR generalizes these tests so they do not depend on the number of preconfigured endpoints in the future. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the FTR tests are written to expect only two preconfigured endpoints. However, there might be more incoming, and this PR generalizes these tests so they do not depend on the number of preconfigured endpoints in the future.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.