Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search] [Onboarding] unskip FTR tests (#202818) #203494

Merged
merged 3 commits into from
Dec 9, 2024
Merged

[8.x] [Search] [Onboarding] unskip FTR tests (#202818) #203494

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65bac2d
[Search] [Onboarding] unskip FTR tests (#202818)
joemcelroy Dec 5, 2024
9176fc7
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
kibanamachine Dec 9, 2024
1d4feb2
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion x-pack/test_serverless/functional/page_objects/svl_api_keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

import expect from '@kbn/expect';
import { SecurityApiKey } from '@elastic/elasticsearch/lib/api/types';
import { FtrProviderContext } from '../ftr_provider_context';

const APIKEY_MASK = '•'.repeat(60);
Expand All @@ -27,6 +28,10 @@ export function SvlApiKeysProvider({ getService, getPageObjects }: FtrProviderCo
await browser.clearSessionStorage();
},

async expectAPIKeyExists() {
await testSubjects.existOrFail('apiKeyFormAPIKey', { timeout: 1000 });
},

async expectAPIKeyAvailable() {
await testSubjects.existOrFail('apiKeyFormAPIKey');
await retry.try(async () => {
Expand Down Expand Up @@ -84,8 +89,19 @@ export function SvlApiKeysProvider({ getService, getPageObjects }: FtrProviderCo
},

async deleteAPIKeys() {
const filterInvalid = (key: SecurityApiKey) => !key.invalidated;

const { api_keys: apiKeys } = await es.security.getApiKey();
await es.security.invalidateApiKey({ ids: apiKeys.map((key) => key.id) });

const validKeys = apiKeys.filter(filterInvalid);

if (validKeys.length === 0) {
return;
}

await es.security.invalidateApiKey({
ids: validKeys.map((key) => key.id),
});
},

async expectCreateApiKeyAction() {
Expand Down
14 changes: 14 additions & 0 deletions x-pack/test_serverless/functional/test_suites/search/elasticsearch_start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const esDeleteAllIndices = getService('esDeleteAllIndices');
const es = getService('es');
const browser = getService('browser');
const retry = getService('retry');

const deleteAllTestIndices = async () => {
await esDeleteAllIndices(['search-*', 'test-*']);
Expand Down Expand Up @@ -95,7 +96,20 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('should show the api key in code view', async () => {
await pageObjects.svlSearchElasticsearchStartPage.expectToBeOnStartPage();
await pageObjects.svlSearchElasticsearchStartPage.clickCodeViewButton();
// sometimes the API key exists in the cluster and its lost in sessionStorage
// if fails we retry to delete the API key and refresh the browser
await retry.try(
async () => {
await pageObjects.svlApiKeys.expectAPIKeyExists();
},
async () => {
await pageObjects.svlApiKeys.deleteAPIKeys();
await browser.refresh();
await pageObjects.svlSearchElasticsearchStartPage.clickCodeViewButton();
}
);
await pageObjects.svlApiKeys.expectAPIKeyAvailable();

const apiKeyUI = await pageObjects.svlApiKeys.getAPIKeyFromUI();
const apiKeySession = await pageObjects.svlApiKeys.getAPIKeyFromSessionStorage();

Expand Down
23 changes: 23 additions & 0 deletions x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const svlSearchNavigation = getService('svlSearchNavigation');
const es = getService('es');
const security = getService('security');
const browser = getService('browser');
const retry = getService('retry');

const esDeleteAllIndices = getService('esDeleteAllIndices');
const indexName = 'test-my-index';
Expand Down Expand Up @@ -89,6 +91,27 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await svlSearchNavigation.navigateToIndexDetailPage(indexName);
});

describe('API key details', () => {
it('should show api key', async () => {
await pageObjects.svlApiKeys.deleteAPIKeys();
await svlSearchNavigation.navigateToIndexDetailPage(indexName);
// sometimes the API key exists in the cluster and its lost in sessionStorage
// if fails we retry to delete the API key and refresh the browser
await retry.try(
async () => {
await pageObjects.svlApiKeys.expectAPIKeyExists();
},
async () => {
await pageObjects.svlApiKeys.deleteAPIKeys();
await browser.refresh();
}
);
await pageObjects.svlApiKeys.expectAPIKeyAvailable();
const apiKey = await pageObjects.svlApiKeys.getAPIKeyFromUI();
await pageObjects.svlSearchIndexDetailPage.expectAPIKeyToBeVisibleInCodeBlock(apiKey);
});
});

it('should show code examples for adding documents', async () => {
await pageObjects.svlSearchIndexDetailPage.expectAddDocumentCodeExamples();
await pageObjects.svlSearchIndexDetailPage.expectSelectedLanguage('python');
Expand Down