Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slo): Prepare for Borealis #203495

Closed
wants to merge 8 commits into from
Closed

chore(slo): Prepare for Borealis #203495

wants to merge 8 commits into from

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Dec 9, 2024

Resolves #203334

🏇🏻 Summary

This PR replaces all deprecated tokens/hooks usage with the correct new values as explained in the linked issue.

Screenshots
screencapture-localhost-5601-kibana-app-dashboards-2024-12-09-15_26_17
screencapture-localhost-5601-kibana-app-dashboards-2024-12-09-15_26_48
screencapture-localhost-5601-kibana-app-slos-2c2e57eb-845e-42c0-b4f8-1c6148d0a1bf-2024-12-09-15_25_53
screencapture-localhost-5601-kibana-app-slos-2024-12-09-14_11_02
screencapture-localhost-5601-kibana-app-slos-2024-12-09-15_24_06
screencapture-localhost-5601-kibana-app-slos-2024-12-09-15_25_41
screencapture-localhost-5601-kibana-app-slos-9870f113-ce06-456d-9078-ffe8e0e86dd5-history-2024-12-09-15_24_52
screencapture-localhost-5601-kibana-app-slos-edit-9870f113-ce06-456d-9078-ffe8e0e86dd5-2024-12-09-15_24_35

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-management Observability Management User Experience Team v8.18.0 labels Dec 9, 2024
@kdelemme kdelemme self-assigned this Dec 9, 2024
@kdelemme kdelemme requested review from kkurstak and patpscal December 9, 2024 20:31
kdelemme
kdelemme commented Dec 9, 2024
View reviewed changes
.../plugins/observability_solution/slo/public/pages/slos/components/card_view/slo_card_item.tsx
Comment on lines -47 to -55
const colors = {
DEGRADING: useEuiBackgroundColor('warning'),
VIOLATED: useEuiBackgroundColor('danger'),
HEALTHY: useEuiBackgroundColor('success'),
NO_DATA: useEuiBackgroundColor('subdued'),
};

return { cardColor: colors[status ?? 'NO_DATA'], colors };
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to x-pack/plugins/observability_solution/slo/public/pages/slos/components/card_view/hooks/use_slo_card_colors.ts and use correct colors.background tokens

@kdelemme kdelemme marked this pull request as ready for review December 9, 2024 20:35
@kdelemme kdelemme requested a review from a team as a code owner December 9, 2024 20:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@patpscal
Copy link

Hi @kdelemme - Would it be possible to provide us with a link to the environment we can test without deploying it locally? It would really help us out. Thank you! cc/ @kkurstak

@kdelemme kdelemme requested a review from a team as a code owner December 11, 2024 14:26
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jasonrhodes
Copy link
Member

/oblt-deploy

This was referenced Dec 11, 2024
Merged
Closed
afharo
afharo requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we want to ship these kibana.yml changes.

Please, remember to remove them when you're done with testing.

config/kibana.yml
@@ -181,3 +181,6 @@
# Maximum number of documents loaded by each shard to generate autocomplete suggestions.
# This value must be a whole number greater than zero. Defaults to 100_000
#unifiedSearch.autocomplete.valueSuggestions.terminateAfter: 100000


uiSettings.experimental.themeSwitcherEnabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, we shouldn't add config to the kibana.yml. Defaults must be set via the defaultValue in the config validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course I will remove this. It is for allowing the designer to test the PR when deployed. Without that they can't turn on the settings...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopssss

shahzad31
shahzad31 reviewed Dec 12, 2024
View reviewed changes
config/kibana.yml Outdated Show resolved Hide resolved
@kdelemme
Copy link
Contributor Author

/oblt-deploy

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 2b0963c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203495-2b0963c270d0

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
slo 862 865 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/slo-schema 183 184 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 851.1KB 850.5KB -618.0B
Unknown metric groups

API count

id before after diff
@kbn/slo-schema 183 184 +1

History

cc @kdelemme

@mgadewoll mgadewoll added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 12, 2024
@kdelemme
Copy link
Contributor Author

Clsoing this as I've included changes for 8.x but we can't backport the borealis change to 8.x

@kdelemme kdelemme closed this Dec 12, 2024
@kdelemme kdelemme deleted the chore/borealis-slo branch December 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 left review comments

@afharo afharo afharo requested changes

@kkurstak kkurstak Awaiting requested review from kkurstak

@patpscal patpscal Awaiting requested review from patpscal

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Audit new EUI Borealis theme
7 participants
@kdelemme @elasticmachine @patpscal @jasonrhodes @shahzad31 @afharo @mgadewoll