Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Obs AI Assistant] Add security configs to API (#201439) #203560

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[8.x] [Obs AI Assistant] Add security configs to API (#201439) #203560

merged 1 commit into from
Dec 11, 2024
+42 −2

Conversation

viduni94
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@viduni94
[Obs AI Assistant] Add security configs to API (elastic#201439)
c195a2c 
## Summary

### Problem
The API
`/internal/observability/assistant/alert_details_contextual_insights`
does not provide explicit authorization settings.

### Solution
Add access privileges (`ai_assistant`) to the above API

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 650c5ca)
@viduni94 viduni94 enabled auto-merge (squash) December 10, 2024 12:57
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Dec 10, 2024
@viduni94 viduni94 mentioned this pull request Dec 10, 2024
Merged
2 tasks
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@viduni94 viduni94 self-assigned this Dec 10, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 10, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: c195a2c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203560-c195a2c77082

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #72 / Alerting improving alert severity should correctly set severity_improving and previous_action_group data in alert document

Metrics [docs]

✅ unchanged

History

cc @viduni94

@viduni94 viduni94 added the Team:Obs AI Assistant Observability AI Assistant label Dec 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 merged commit 081cae6 into elastic:8.x Dec 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

@viduni94 viduni94

Labels
backport ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viduni94 @elasticmachine @neptunian