Discover histogram debugging v4 #204162

kertal · 2024-12-13T04:59:03Z

Summary

This PR attempts to bring back our functional test for the number of requests when using ES|QL by reducing the sources of truth in terms of state that the code relys on.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

…-fix'

…na into discover-histogram-debugging

…debugging

kertal · 2024-12-13T04:59:13Z

/ci

elasticmachine · 2024-12-13T04:59:17Z

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

Click to trigger kibana-pull-request for this PR!
Click to trigger kibana-deploy-project-from-pr for this PR!

…debugging-v4

kertal · 2024-12-13T08:20:08Z

/ci

kertal · 2024-12-16T15:01:19Z

/ci

kertal · 2024-12-16T22:23:06Z

/ci

kertal · 2024-12-17T05:56:25Z

/ci

kertal · 2024-12-17T08:21:58Z

/ci

kertal · 2024-12-17T11:46:35Z

/ci

kertal · 2024-12-17T12:29:00Z

/ci

kertal · 2024-12-17T15:06:41Z

/ci

elasticmachine · 2024-12-17T16:04:43Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 53b338a

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #56 / discover discover field visualize button should visualize correctly ES|QL queries in Discover
[job] [logs] FTR Configs #56 / discover discover field visualize button should visualize correctly ES|QL queries in Discover
[job] [logs] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group6.ts / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] FTR Configs #12 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] FTR Configs #53 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] FTR Configs #71 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] FTR Configs #12 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] FTR Configs #53 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] FTR Configs #71 / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group6.ts / discover/esql discover esql view inspector shows Discover and Lens requests in Inspector
[job] [logs] test/functional/apps/discover/group3/config.ts / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group5.ts / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] FTR Configs #67 / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] test/functional/apps/discover/group3/config.ts / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group5.ts / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] FTR Configs #67 / discover/group3 discover request counts data view mode should send no more than 2 requests (documents + chart) when toggling the chart visibility
[job] [logs] FTR Configs #9 / discover/group7 indexpattern without timefield should allow switching from a saved search with a time field to a saved search without a time field
[job] [logs] FTR Configs #9 / discover/group7 indexpattern without timefield should allow switching from a saved search with a time field to a saved search without a time field
[job] [logs] Jest Tests #5 / test fetchAll should only fail totalHits$ query not main$ for error from that query
[job] [logs] Jest Tests #5 / test fetchAll should only fail totalHits$ query not main$ for error from that query
[job] [logs] FTR Configs #77 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products
[job] [logs] FTR Configs #77 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products
[job] [logs] Jest Tests #5 / useDiscoverHistogram state should exclude totalHitsStatus and totalHitsResult from Unified Histogram state updates
[job] [logs] Jest Tests #5 / useDiscoverHistogram state should exclude totalHitsStatus and totalHitsResult from Unified Histogram state updates
[job] [logs] Jest Tests #5 / useDiscoverHistogram state should sync the state container state with Unified Histogram
[job] [logs] Jest Tests #5 / useDiscoverHistogram state should sync the state container state with Unified Histogram

History

cc @kertal

kertal · 2024-12-23T19:45:21Z

closing, experimental

kertal and others added 17 commits December 6, 2024 10:04

Initial histogram debugging

a472a2a

Fixing tests and lining

3e0ffc7

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

e5b1b4c

…-fix'

Fix test

0204ac5

Merge branch 'discover-histogram-debugging' of github.com:kertal/kiba…

7d0d206

…na into discover-histogram-debugging

Fix functional test

51fbf2e

Merge remote-tracking branch 'upstream/main' into discover-histogram-…

2c39b21

…debugging

Rename to sendFetchStartMsg

afe95ca

Update sendResetMsg

81af64a

Update use_discover_histogram.ts

19bdbff

iterate

1023a8e

Add tests

87a3fc4

Merge remote-tracking branch 'upstream/main' into discover-histogram-…

044ad48

…debugging

Add tests

7fa23e3

Merge main, fix conflict

529222a

Fix tests

7d1430d

resolve redundant histogram requests

1748ccc

Merge remote-tracking branch 'upstream/main' into discover-histogram-…

b798a94

…debugging-v4

kertal self-assigned this Dec 13, 2024

kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. release_note:fix labels Dec 13, 2024

Fix functional test

55c37f8

Restore ESQL request count tests

6a701bf

Fix tests

44fca45

Undo changes to fix tests

aba11dd

Attempt to reduce requests

7fad003

Fix types

c53df8c

Fix types

98051a9

Fix types, again

53b338a

kertal closed this Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Discover histogram debugging v4 #204162

Discover histogram debugging v4 #204162

kertal commented Dec 13, 2024 •

edited

Loading

kertal commented Dec 13, 2024

elasticmachine commented Dec 13, 2024

kertal commented Dec 13, 2024

kertal commented Dec 16, 2024

kertal commented Dec 16, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

elasticmachine commented Dec 17, 2024 •

edited

Loading

kertal commented Dec 23, 2024

Discover histogram debugging v4 #204162

Discover histogram debugging v4 #204162

Conversation

kertal commented Dec 13, 2024 • edited Loading

Summary

Checklist

Identify risks

kertal commented Dec 13, 2024

elasticmachine commented Dec 13, 2024

kertal commented Dec 13, 2024

kertal commented Dec 16, 2024

kertal commented Dec 16, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

kertal commented Dec 17, 2024

elasticmachine commented Dec 17, 2024 • edited Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

kertal commented Dec 23, 2024

kertal commented Dec 13, 2024 •

edited

Loading

elasticmachine commented Dec 17, 2024 •

edited

Loading