Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sustainable Kibana Architecture: Relocate script v3 #204239

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Sustainable Kibana Architecture: Relocate script v3 #204239

merged 2 commits into from
Dec 13, 2024

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 13, 2024 •
edited by kibanamachine
Loading

Summary

  • Added link to rebase guideline in PR description.
  • Do not count elasticmachine commits as manual.
  • Replace references in CODEOWNERS file manual section.
  • Update README prerequisites.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 13, 2024
@gsoldevila gsoldevila requested a review from a team as a code owner December 13, 2024 15:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila enabled auto-merge (squash) December 13, 2024 15:24
afharo
afharo reviewed Dec 13, 2024
View reviewed changes
packages/kbn-relocate/README.md Outdated
Comment on lines 17 to 21
It's highly recommended that you disable the pre-commit hook, as it often causes the script to fail:

```sh
mv .git/hooks/pre-commit .git/hooks/pre-commit.sample
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing this, the script could add --no-verify to the commit command.

@gsoldevila gsoldevila requested a review from afharo December 13, 2024 21:21
@gsoldevila gsoldevila merged commit 39732db into elastic:main Dec 13, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12324461266

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #73 / Serverless Observability - Deployment-agnostic API integration tests SyntheticsAPITests getSyntheticsMonitors get one monitor should get by id

Metrics [docs]

✅ unchanged

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Rules migration] Add comments tab in the details flyout (#11385) (#204084)
- [ai][assistant] Create AI Assistant Icon, Avatar, Beacon (#203879)
- kibana-management team module move (#203883)
- [Automatic Import] update path automatic import (#203751)
- [Inference Connector] Changed UI/UX due to the new RFC for the _inference/_service (#203363)
- [EDR Workflows] Revert skipped Cypress tests (#204216)

Manual backport

To create the backport manually run:

node scripts/backport --pr 204239

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 16, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

9 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204239 locally

@gsoldevila gsoldevila removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 30, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 30, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsoldevila @elasticmachine @kibanamachine @afharo