Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Remove invalid rule type warnings #204366

Merged
merged 7 commits into from
Jan 2, 2025
Merged

[ResponseOps][Rules] Remove invalid rule type warnings #204366

merged 7 commits into from
Jan 2, 2025

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Dec 16, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #204101

@js-jankisalvi js-jankisalvi self-assigned this Dec 16, 2024
@js-jankisalvi js-jankisalvi changed the title [ResponseOps][Rules]remove invalidRuleTypeIds warn [ResponseOps][Rules]remove invalid rule type warnings Dec 17, 2024
@js-jankisalvi js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 labels Dec 17, 2024
@js-jankisalvi js-jankisalvi marked this pull request as ready for review December 17, 2024 10:47
@js-jankisalvi js-jankisalvi requested review from a team as code owners December 17, 2024 10:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@js-jankisalvi js-jankisalvi changed the title [ResponseOps][Rules]remove invalid rule type warnings [ResponseOps][Rules] Remove invalid rule type warnings Dec 23, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi merged commit 4ae8b67 into elastic:main Jan 2, 2025
8 checks passed
@js-jankisalvi js-jankisalvi deleted the o11y-invalid-rule-types-warn branch January 2, 2025 15:38
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12584877790

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2025
@js-jankisalvi
[ResponseOps][Rules] Remove invalid rule type warnings (elastic#204366)
be25235 
## Summary

Fixes elastic#204101

(cherry picked from commit 4ae8b67)
@kibanamachine kibanamachine mentioned this pull request Jan 2, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2025
@kibanamachine @js-jankisalvi
[8.x] [ResponseOps][Rules] Remove invalid rule type warnings (#204366) (
5481699 
#205406)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Remove invalid rule type warnings
(#204366)](#204366)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T15:38:33Z","message":"[ResponseOps][Rules]
Remove invalid rule type warnings (#204366)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/204101","sha":"4ae8b674947a2ce45fea48277d8d409135d55f75","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[ResponseOps][Rules]
Remove invalid rule type
warnings","number":204366,"url":"https://github.com/elastic/kibana/pull/204366","mergeCommit":{"message":"[ResponseOps][Rules]
Remove invalid rule type warnings (#204366)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/204101","sha":"4ae8b674947a2ce45fea48277d8d409135d55f75"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204366","number":204366,"mergeCommit":{"message":"[ResponseOps][Rules]
Remove invalid rule type warnings (#204366)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/204101","sha":"4ae8b674947a2ce45fea48277d8d409135d55f75"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Janki Salvi <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
@js-jankisalvi @cqliu1
[ResponseOps][Rules] Remove invalid rule type warnings (elastic#204366)
4730a94 
## Summary

Fixes elastic#204101
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@js-jankisalvi @CAWilson94
[ResponseOps][Rules] Remove invalid rule type warnings (elastic#204366)
1c8f86b 
## Summary

Fixes elastic#204101
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@js-jankisalvi @viduni94
[ResponseOps][Rules] Remove invalid rule type warnings (elastic#204366)
75ec06e 
## Summary

Fixes elastic#204101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@adcoelho adcoelho adcoelho approved these changes

Assignees

@js-jankisalvi js-jankisalvi

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid rule type warnings in O11y serverless projects
5 participants
@js-jankisalvi @elasticmachine @kibanamachine @adcoelho @shahzad31