[ML] AIOps: Field stats fix #204403
Merged
[ML] AIOps: Field stats fix #204403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
cc @walterra |
peteharverson
approved these changes
Dec 16, 2024
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Fixes a regression introduced in elastic#203579. `EuiText` accepts EUI colors like `primary` as well as hex colors. The PR above introduced `getPercentageColor()` which assumed all colors passed in are hex colors. In case it was an EUI color token the code threw an error and the fields stats popover wouldn't fully render. This fix adds an additional check to apply `makeHighContrastColor` only if the color provided is a hex color. Before:  After:  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Fixes a regression introduced in elastic#203579. `EuiText` accepts EUI colors like `primary` as well as hex colors. The PR above introduced `getPercentageColor()` which assumed all colors passed in are hex colors. In case it was an EUI color token the code threw an error and the fields stats popover wouldn't fully render. This fix adds an additional check to apply `makeHighContrastColor` only if the color provided is a hex color. Before:  After:  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in #203579.
EuiTextaccepts EUI colors likeprimaryas well as hex colors. The PR above introducedgetPercentageColor()which assumed all colors passed in are hex colors. In case it was an EUI color token the code threw an error and the fields stats popover wouldn't fully render. This fix adds an additional check to applymakeHighContrastColoronly if the color provided is a hex color.Before:
After:
Checklist
release_note:*label is applied per the guidelines