Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent-type-imports eslint rule in obs-ux-infra_services-team owned plugins #204407

Conversation

miloszmarcinkowski
Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski commented Dec 16, 2024

Summary

This PR enforces consistent-type-imports eslint rule in x-pack/plugins/observability_solution/* plugins owned by obs-ux-infra_services-team.

Detailed list of plugins:

  • x-pack/plugins/observability_solution/apm,
  • x-pack/plugins/observability_solution/apm_data_access,
  • x-pack/plugins/observability_solution/infra,
  • x-pack/plugins/observability_solution/metrics_data_access,
  • x-pack/plugins/observability_solution/profiling,
  • x-pack/plugins/observability_solution/profiling_data_access

Script for fixing eslint rules in above plugins:

yarn eslint --no-error-on-unmatched-pattern --quiet --fix "x-pack/plugins/observability_solution/apm/**/*.{js,mjs,ts,tsx}" "x-pack/plugins/observability_solution/apm_data_access/**/*.{js,mjs,ts,tsx}" "x-pack/plugins/observability_solution/infra/**/*.{js,mjs,ts,tsx}" "x-pack/plugins/observability_solution/inventory/**/*.{js,mjs,ts,tsx}" "x-pack/plugins/observability_solution/metrics_data_access/**/*.{js,mjs,ts,tsx}" "x-pack/plugins/observability_solution/profiling/**/*.{js,mjs,ts,tsx}" "x-pack/plugins/observability_solution/profiling_data_access/**/*.{js,mjs,ts,tsx}"

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 16, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@miloszmarcinkowski miloszmarcinkowski changed the title Add eslint consistent type imports rule Add consistent-type-imports eslint rule in obs-ux-infra_services-team owned plugins Dec 16, 2024
@miloszmarcinkowski miloszmarcinkowski added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 16, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 16, 2024

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #76 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products
  • [job] [logs] FTR Configs #76 / Upgrade Assistant Elasticsearch deprecation logs GET /api/upgrade_assistant/deprecation_logging /count should filter out the deprecation from Elastic products

History

@miloszmarcinkowski miloszmarcinkowski force-pushed the add-eslint-consistent-type-imports-rule branch from cbafe24 to 851ea0b Compare December 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants