-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[One Discover] Display stacktrace in the logs overview tab #204521
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
360019f
Create key-value-metadata-table package for the local variables table
gbamparop b41227d
Create package for event stacktrace
gbamparop 6d1ad15
Update license
gbamparop b86953e
Delete metadata table from APM
gbamparop 8939e2a
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine dc0d679
Mark kbn-apm-types as platform/shared
gbamparop ca3ad1f
Mark kbn-key-value-metadata-table as platform/shared
gbamparop ee1df5b
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop 09296d5
Add stacktrace to the overview tab
gbamparop f3a7554
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine 4411afa
Fix types
gbamparop fae18f2
Fix jest config
gbamparop 2883cea
Fix Jest tests
gbamparop 8b0965f
Fix Jest tests
gbamparop 1321d95
Clean up code in logs overview stacktrace
gbamparop bda64c4
Add checks to not display the stacktrace section if there are no rele…
gbamparop 0239a95
Add stacktrace section only when there is data available
gbamparop 82c9f10
Handle cases when the data format is not the one expected
gbamparop 2db6a10
Migrate styled components to emotion
gbamparop 947f4a7
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop 73d2bc0
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 26dc723
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 94863ab
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop 4f6bdb9
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine afed5ff
Fix CODEOWNERS
gbamparop 6838a56
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 315327d
Remove kibanaReact dependency
gbamparop aaebe33
Update jest config path in README
gbamparop 9280aab
Add package.json to kbn-apm-types package
gbamparop a98458d
Fix funtional tests
gbamparop e469f4e
Add jest tests
gbamparop c93fa17
Update functional tests
gbamparop ce72d6e
Fix synthtrace types
gbamparop 23fbe85
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop 997e251
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine b16b154
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop 4b3d5cd
Fix typo
gbamparop 23c45e4
Import StackframeWithLineContext as a type
gbamparop 1e0567e
Change font size for exception title
gbamparop 63dc8a2
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop b4136ae
Remove emotion.d.ts from packages
gbamparop 4df34cf
Rename flattenObject function to getFlattenedKeyValuePairs
gbamparop 818bd02
Add horizontal rule after the stacktrace section
gbamparop 346a621
Remove IntlProvider from tests
gbamparop 79a2b20
Merge remote-tracking branch 'upstream/main' into discover-logs-stack…
gbamparop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,4 +23,4 @@ | |
"kibanaUtils" | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...oc_viewer/public/components/doc_viewer_logs_overview/logs_overview_stacktrace_section.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the "Elastic License | ||
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
* Public License v 1"; you may not use this file except in compliance with, at | ||
* your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
* License v3.0 only", or the "Server Side Public License, v 1". | ||
*/ | ||
import { EuiAccordion, EuiHorizontalRule, EuiTitle, useGeneratedHtmlId } from '@elastic/eui'; | ||
import { DataTableRecord } from '@kbn/discover-utils'; | ||
import { i18n } from '@kbn/i18n'; | ||
import React from 'react'; | ||
import type { DataView } from '@kbn/data-views-plugin/public'; | ||
import { StacktraceContent } from './sub_components/stacktrace/stacktrace_content'; | ||
|
||
const stacktraceAccordionTitle = i18n.translate( | ||
'unifiedDocViewer.docView.logsOverview.accordion.title.stacktrace', | ||
{ | ||
defaultMessage: 'Stacktrace', | ||
} | ||
); | ||
|
||
export function LogsOverviewStacktraceSection({ | ||
hit, | ||
dataView, | ||
}: { | ||
hit: DataTableRecord; | ||
dataView: DataView; | ||
}) { | ||
const accordionId = useGeneratedHtmlId({ | ||
prefix: stacktraceAccordionTitle, | ||
}); | ||
|
||
return ( | ||
<> | ||
<EuiAccordion | ||
id={accordionId} | ||
buttonContent={ | ||
<EuiTitle size="xs"> | ||
<p>{stacktraceAccordionTitle}</p> | ||
</EuiTitle> | ||
} | ||
paddingSize="m" | ||
initialIsOpen={false} | ||
data-test-subj="unifiedDocViewLogsOverviewStacktraceAccordion" | ||
> | ||
<StacktraceContent hit={hit} dataView={dataView} /> | ||
</EuiAccordion> | ||
<EuiHorizontalRule margin="xs" /> | ||
</> | ||
); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we probably need some spacing here to separate from the AI Assistant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, a horizontal rule was added in 818bd02 to match the other sections:
Quality
Stacktrace