[Rules migration] Retry failed translations (#11383) #204619
Merged
+527
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, installed, skipped etc.) (elastic#11383)
e40pud
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
semd
reviewed
Dec 17, 2024
...ugins/security_solution/public/siem_migrations/rules/components/rules_table/bulk_actions.tsx
Outdated
Show resolved
Hide resolved
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
semd
reviewed
Dec 17, 2024
...ugins/security_solution/public/siem_migrations/rules/components/rules_table/bulk_actions.tsx
Outdated
Show resolved
Hide resolved
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
semd
reviewed
Dec 19, 2024
src/plugins/visualizations/public/legacy/embeddable/visualize_embeddable.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @e40pud |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
…204619) ## Summary [Internal link](elastic/security-team#10820) to the feature details These changes add a functionality which allows user to retry failed migration rules. ### Other tasks and fixes * Integrated `MigrationReadyPanel` and `MigrationProgressPanel` to show migration's `ready` and `running` states * Migration stats pooling issue caused by waiting while there are no pending migrations left. If any other operation triggers `startPooling` during the waiting it will be ignored and thus latest stats will never come back. > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. ### Testing note 1. Make sure you have a SIEM migration with failed rules 2. Open that migration via `Security > Rules > SIEM Rules Migrations > {#MIGRATION_WITH_FAILED_RULES}` 3. You should see a `Reprocess rules (#)` button which triggers failed rules reprocessing ## Screen recording https://github.com/user-attachments/assets/d33dc4a0-1791-4869-aa8d-b0322b5f19c3 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e4586da)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
…204619) ## Summary [Internal link](elastic/security-team#10820) to the feature details These changes add a functionality which allows user to retry failed migration rules. ### Other tasks and fixes * Integrated `MigrationReadyPanel` and `MigrationProgressPanel` to show migration's `ready` and `running` states * Migration stats pooling issue caused by waiting while there are no pending migrations left. If any other operation triggers `startPooling` during the waiting it will be ignored and thus latest stats will never come back. > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. ### Testing note 1. Make sure you have a SIEM migration with failed rules 2. Open that migration via `Security > Rules > SIEM Rules Migrations > {#MIGRATION_WITH_FAILED_RULES}` 3. You should see a `Reprocess rules (#)` button which triggers failed rules reprocessing ## Screen recording https://github.com/user-attachments/assets/d33dc4a0-1791-4869-aa8d-b0322b5f19c3 --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…205878) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration] Retry failed translations (#11383) (#204619)](#204619) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T12:21:17Z","message":"[Rules migration] Retry failed translations (#11383) (#204619)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a functionality which allows user to retry failed\r\nmigration rules.\r\n\r\n### Other tasks and fixes\r\n\r\n* Integrated `MigrationReadyPanel` and `MigrationProgressPanel` to show\r\nmigration's `ready` and `running` states\r\n* Migration stats pooling issue caused by waiting while there are no\r\npending migrations left. If any other operation triggers `startPooling`\r\nduring the waiting it will be ignored and thus latest stats will never\r\ncome back.\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.\r\n\r\n### Testing note\r\n\r\n1. Make sure you have a SIEM migration with failed rules\r\n2. Open that migration via `Security > Rules > SIEM Rules Migrations >\r\n{#MIGRATION_WITH_FAILED_RULES}`\r\n3. You should see a `Reprocess rules (#)` button which triggers failed\r\nrules reprocessing\r\n\r\n## Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d33dc4a0-1791-4869-aa8d-b0322b5f19c3\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e4586dac809ebfe618223aae33e9723e6cc38384","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules migration] Retry failed translations (#11383)","number":204619,"url":"https://github.com/elastic/kibana/pull/204619","mergeCommit":{"message":"[Rules migration] Retry failed translations (#11383) (#204619)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a functionality which allows user to retry failed\r\nmigration rules.\r\n\r\n### Other tasks and fixes\r\n\r\n* Integrated `MigrationReadyPanel` and `MigrationProgressPanel` to show\r\nmigration's `ready` and `running` states\r\n* Migration stats pooling issue caused by waiting while there are no\r\npending migrations left. If any other operation triggers `startPooling`\r\nduring the waiting it will be ignored and thus latest stats will never\r\ncome back.\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.\r\n\r\n### Testing note\r\n\r\n1. Make sure you have a SIEM migration with failed rules\r\n2. Open that migration via `Security > Rules > SIEM Rules Migrations >\r\n{#MIGRATION_WITH_FAILED_RULES}`\r\n3. You should see a `Reprocess rules (#)` button which triggers failed\r\nrules reprocessing\r\n\r\n## Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d33dc4a0-1791-4869-aa8d-b0322b5f19c3\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e4586dac809ebfe618223aae33e9723e6cc38384"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204619","number":204619,"mergeCommit":{"message":"[Rules migration] Retry failed translations (#11383) (#204619)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a functionality which allows user to retry failed\r\nmigration rules.\r\n\r\n### Other tasks and fixes\r\n\r\n* Integrated `MigrationReadyPanel` and `MigrationProgressPanel` to show\r\nmigration's `ready` and `running` states\r\n* Migration stats pooling issue caused by waiting while there are no\r\npending migrations left. If any other operation triggers `startPooling`\r\nduring the waiting it will be ignored and thus latest stats will never\r\ncome back.\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.\r\n\r\n### Testing note\r\n\r\n1. Make sure you have a SIEM migration with failed rules\r\n2. Open that migration via `Security > Rules > SIEM Rules Migrations >\r\n{#MIGRATION_WITH_FAILED_RULES}`\r\n3. You should see a `Reprocess rules (#)` button which triggers failed\r\nrules reprocessing\r\n\r\n## Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d33dc4a0-1791-4869-aa8d-b0322b5f19c3\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e4586dac809ebfe618223aae33e9723e6cc38384"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internal link to the feature details
These changes add a functionality which allows user to retry failed migration rules.
Other tasks and fixes
MigrationReadyPanelandMigrationProgressPanelto show migration'sreadyandrunningstatesstartPoolingduring the waiting it will be ignored and thus latest stats will never come back.Note
This feature needs
siemMigrationsEnabledexperimental flag enabled to work.Testing note
Security > Rules > SIEM Rules Migrations > {#MIGRATION_WITH_FAILED_RULES}Reprocess rules (#)button which triggers failed rules reprocessingScreen recording
Screen.Recording.2024-12-17.at.17.53.37.mov