Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Security preparation for Kibana Borealis theme #204653

Closed
wants to merge 5 commits into from

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Dec 17, 2024

Summary

it fixes https://github.com/elastic/security-team/issues/11230

This PR prepares Cloud Security pages for the Kibana Borealis theme, by addressing Color issues detected during the initial validation with the usage of viz tokens on the Misconfiguration and Vulnerabilities pages.

During our investigations, we initially tried to use euiPaletteForStatus or adjust the tokens to the closest Eui Colors tokens but we could not find enough contrast to create a Pallete for Severity status colors using the tokens provided, so we created a custom colour palette by using the values of the Visualization tokens.

Screenshot (Light and Dark mode Borealis Theme)

Screenshot 2024-12-17 at 5 25 46 PM
Screenshot 2024-12-17 at 5 25 51 PM

Screenshot 2024-12-17 at 5 25 21 PM
Screenshot 2024-12-17 at 5 24 52 PM
Screenshot 2024-12-17 at 5 24 02 PM
Screenshot 2024-12-17 at 5 23 44 PM
Screenshot 2024-12-17 at 5 23 37 PM

@opauloh opauloh requested a review from maxcold December 17, 2024 20:33
@opauloh opauloh added v9.0.0 Team:Cloud Security Cloud Security team related backport:skip This commit does not require backporting labels Dec 17, 2024
@opauloh opauloh marked this pull request as ready for review December 17, 2024 20:40
@opauloh opauloh requested a review from a team as a code owner December 17, 2024 20:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh added the release_note:skip Skip the PR/issue when compiling release notes label Dec 17, 2024
@opauloh opauloh marked this pull request as draft December 17, 2024 20:41
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 17, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for critical severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for critical severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for high severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for high severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for low severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for low severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for low severity score for undefined value
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for low severity score for undefined value
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for medium severity score
  • [job] [logs] Jest Tests #18 / getCvsScoreColor returns correct color for medium severity score
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for CRITICAL severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for CRITICAL severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for HIGH severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for HIGH severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for LOW severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for LOW severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for MEDIUM severity
  • [job] [logs] Jest Tests #18 / getSeverityStatusColor should return the correct color for MEDIUM severity
  • [job] [logs] Jest Tests #18 / getVulnerabilitiesAggregationCount should return stats for low, medium, high, and critical vulnerabilities
  • [job] [logs] Jest Tests #18 / getVulnerabilitiesAggregationCount should return stats for low, medium, high, and critical vulnerabilities

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 503.0KB 502.8KB -223.0B
securitySolution 14.8MB 14.8MB -229.0B
total -452.0B

History

@maxcold
Copy link
Contributor

maxcold commented Dec 23, 2024

The PR can be closed, as going with hardcoded colors seems to not be a viable option after discussions in the related threads and tickets, see https://github.com/elastic/security-team/issues/11230#issuecomment-2555637365 .
We should use the new severity palette provided by EUI and for cases when we can't find a proper color in the severity palette (eg. there is no green currently), we can consider to use viz color as a temporary solution

@maxcold maxcold closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants