[Kibana Overview] Shift SCSS import and lazy-load main component #204661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
ryankeairns
approved these changes
Dec 18, 2024
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment)
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment)
mykolaharmash
added a commit
to mykolaharmash/kibana
that referenced
this pull request
Jan 2, 2025
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment)
mykolaharmash
added a commit
to mykolaharmash/kibana
that referenced
this pull request
Jan 3, 2025
Dosant
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment) (cherry picked from commit 1861bbc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment) (cherry picked from commit 1861bbc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mykolaharmash
added a commit
to mykolaharmash/kibana
that referenced
this pull request
Jan 3, 2025
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
#204661) (#205484) # Backport This will backport the following commits from `main` to `8.x`: - [[Kibana Overview] Shift SCSS import and lazy-load main component (#204661)](#204661) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T15:10:02Z","message":"[Kibana Overview] Shift SCSS import and lazy-load main component (#204661)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nThe purpose of this PR is to reduce the page load bundle size of the\r\n`kibanaOverview` plugin.\r\n\r\nConverts the main component of the `kibanaOverview` plugin to be lazy\r\nloaded, and shifts the import of the main SCSS file to be imported from\r\nthe lazily-loaded component. This PR does not include any changes that\r\nwould be noticeable by end-users. It changes the internals to use a\r\ndifferent technology for styling components.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2. https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360","sha":"1861bbc16a92afd1a2bb88521bb2110746079efd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Kibana Overview] Shift SCSS import and lazy-load main component","number":204661,"url":"https://github.com/elastic/kibana/pull/204661","mergeCommit":{"message":"[Kibana Overview] Shift SCSS import and lazy-load main component (#204661)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nThe purpose of this PR is to reduce the page load bundle size of the\r\n`kibanaOverview` plugin.\r\n\r\nConverts the main component of the `kibanaOverview` plugin to be lazy\r\nloaded, and shifts the import of the main SCSS file to be imported from\r\nthe lazily-loaded component. This PR does not include any changes that\r\nwould be noticeable by end-users. It changes the internals to use a\r\ndifferent technology for styling components.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2. https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360","sha":"1861bbc16a92afd1a2bb88521bb2110746079efd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204661","number":204661,"mergeCommit":{"message":"[Kibana Overview] Shift SCSS import and lazy-load main component (#204661)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nThe purpose of this PR is to reduce the page load bundle size of the\r\n`kibanaOverview` plugin.\r\n\r\nConverts the main component of the `kibanaOverview` plugin to be lazy\r\nloaded, and shifts the import of the main SCSS file to be imported from\r\nthe lazily-loaded component. This PR does not include any changes that\r\nwould be noticeable by end-users. It changes the internals to use a\r\ndifferent technology for styling components.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2. https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360","sha":"1861bbc16a92afd1a2bb88521bb2110746079efd"}}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
mykolaharmash
added a commit
to mykolaharmash/kibana
that referenced
this pull request
Jan 6, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment)
tsullivan
added
technical debt
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/elastic/kibana-team/issues/1082
The purpose of this PR is to reduce the page load bundle size of the
kibanaOverviewplugin.Converts the main component of the
kibanaOverviewplugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components.References