[ML] Fixes inference timeout check in File Upload #204722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
the
ci:project-deploy-elasticsearch
|
PR Project deployment started at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/211 |
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/211 |
|
PR Project deployment started at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/212 |
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/212 |
|
PR Project deployment started at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/213 |
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/213 |
jgowdyelastic
added
:ml
Feature:File and Index Data Viz
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
Dec 24, 2024
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 24, 2024
Fixes issue in serverless where the inference call to deploy elser times out, which is expected, but returns with an unexpected `500` error code. This causes the UI to stop the upload process.  This PR increases the timeout length to 10mins and allows for `500` errors just in case. Testing this shows that with the extra timeout time in kibana, another timeout happens at 1min but this returns with an expected `408`. Therefore allowing for `500`s might not be needed, but I don't think there is any harm. (cherry picked from commit 155bdd0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 24, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] File upload fixing inference timeout check (#204722)](#204722) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-24T20:23:14Z","message":"[ML] File upload fixing inference timeout check (#204722)\n\nFixes issue in serverless where the inference call to deploy elser times\r\nout, which is expected, but returns with an unexpected `500` error code.\r\nThis causes the UI to stop the upload process.\r\n\r\n\r\n\r\n\r\nThis PR increases the timeout length to 10mins and allows for `500`\r\nerrors just in case.\r\nTesting this shows that with the extra timeout time in kibana, another\r\ntimeout happens at 1min but this returns with an expected `408`.\r\nTherefore allowing for `500`s might not be needed, but I don't think\r\nthere is any harm.","sha":"155bdd02af3418d4b5d2228ea034d12c9146f934","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","backport:version","v8.18.0"],"title":"[ML] File upload fixing inference timeout check","number":204722,"url":"https://github.com/elastic/kibana/pull/204722","mergeCommit":{"message":"[ML] File upload fixing inference timeout check (#204722)\n\nFixes issue in serverless where the inference call to deploy elser times\r\nout, which is expected, but returns with an unexpected `500` error code.\r\nThis causes the UI to stop the upload process.\r\n\r\n\r\n\r\n\r\nThis PR increases the timeout length to 10mins and allows for `500`\r\nerrors just in case.\r\nTesting this shows that with the extra timeout time in kibana, another\r\ntimeout happens at 1min but this returns with an expected `408`.\r\nTherefore allowing for `500`s might not be needed, but I don't think\r\nthere is any harm.","sha":"155bdd02af3418d4b5d2228ea034d12c9146f934"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204722","number":204722,"mergeCommit":{"message":"[ML] File upload fixing inference timeout check (#204722)\n\nFixes issue in serverless where the inference call to deploy elser times\r\nout, which is expected, but returns with an unexpected `500` error code.\r\nThis causes the UI to stop the upload process.\r\n\r\n\r\n\r\n\r\nThis PR increases the timeout length to 10mins and allows for `500`\r\nerrors just in case.\r\nTesting this shows that with the extra timeout time in kibana, another\r\ntimeout happens at 1min but this returns with an expected `408`.\r\nTherefore allowing for `500`s might not be needed, but I don't think\r\nthere is any harm.","sha":"155bdd02af3418d4b5d2228ea034d12c9146f934"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
Fixes issue in serverless where the inference call to deploy elser times out, which is expected, but returns with an unexpected `500` error code. This causes the UI to stop the upload process.  This PR increases the timeout length to 10mins and allows for `500` errors just in case. Testing this shows that with the extra timeout time in kibana, another timeout happens at 1min but this returns with an expected `408`. Therefore allowing for `500`s might not be needed, but I don't think there is any harm.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
Fixes issue in serverless where the inference call to deploy elser times out, which is expected, but returns with an unexpected `500` error code. This causes the UI to stop the upload process.  This PR increases the timeout length to 10mins and allows for `500` errors just in case. Testing this shows that with the extra timeout time in kibana, another timeout happens at 1min but this returns with an expected `408`. Therefore allowing for `500`s might not be needed, but I don't think there is any harm.
peteharverson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in serverless where the inference call to deploy elser times out, which is expected, but returns with an unexpected
500error code.This causes the UI to stop the upload process.
This PR increases the timeout length to 10mins and allows for
500errors just in case.Testing this shows that with the extra timeout time in kibana, another timeout happens at 1min but this returns with an expected
408. Therefore allowing for500s might not be needed, but I don't think there is any harm.