Add @kbn/shared-ux-router to shared bundle
#204786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
changed the title
@kbn/shared-ux-router to shared bundle
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Ikuni17
approved these changes
Dec 19, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Dec 30, 2024
## Summary Part of elastic#204761 . This package is used by every app and I thought it is worth adding it to the shared bundle. Especially since it is already part of Bazel. (cherry picked from commit b64ff10)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
that referenced
this pull request
Dec 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Add `@kbn/shared-ux-router` to shared bundle (#204786)](#204786) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T12:44:44Z","message":"Add `@kbn/shared-ux-router` to shared bundle (#204786)\n\n## Summary\r\n\r\nPart of #204761 . This package\r\nis used by every app and I thought it is worth adding it to the shared\r\nbundle. Especially since it is already part of Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":204786,"url":"https://github.com/elastic/kibana/pull/204786","mergeCommit":{"message":"Add `@kbn/shared-ux-router` to shared bundle (#204786)\n\n## Summary\r\n\r\nPart of #204761 . This package\r\nis used by every app and I thought it is worth adding it to the shared\r\nbundle. Especially since it is already part of Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204786","number":204786,"mergeCommit":{"message":"Add `@kbn/shared-ux-router` to shared bundle (#204786)\n\n## Summary\r\n\r\nPart of #204761 . This package\r\nis used by every app and I thought it is worth adding it to the shared\r\nbundle. Especially since it is already part of Bazel.","sha":"b64ff102045585b2f28ced7a612edcafd0944b6e"}}]}] BACKPORT-->
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Part of elastic#204761 . This package is used by every app and I thought it is worth adding it to the shared bundle. Especially since it is already part of Bazel.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Part of elastic#204761 . This package is used by every app and I thought it is worth adding it to the shared bundle. Especially since it is already part of Bazel.
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Part of elastic#204761 . This package is used by every app and I thought it is worth adding it to the shared bundle. Especially since it is already part of Bazel.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Part of elastic#204761 . This package is used by every app and I thought it is worth adding it to the shared bundle. Especially since it is already part of Bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #204761 . This package is used by every app and I thought it is worth adding it to the shared bundle. Especially since it is already part of Bazel.