Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES body removal] @elastic/security-data-analytics #204852

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 19, 2024

Summary

Attempt to remove the deprecated body in the ES client.

@afharo afharo added backport:skip This commit does not require backporting backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@afharo afharo self-assigned this Dec 19, 2024
@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Dec 19, 2024
@afharo afharo marked this pull request as ready for review December 19, 2024 11:24
@afharo afharo requested a review from a team as a code owner December 19, 2024 11:24
Copy link
Contributor

@szaffarano szaffarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks for tackling it Alejandro

@afharo afharo enabled auto-merge (squash) December 30, 2024 16:08
@afharo afharo merged commit a3858a3 into elastic:main Dec 30, 2024
9 checks passed
@afharo afharo deleted the esclient/remove-deprecated-body/elastic/security-data-analytics branch December 30, 2024 17:36
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12549915811

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @afharo

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 30, 2024
…ytics` (#204852) (#205282)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES `body` removal]
`@elastic/security-data-analytics`
(#204852)](#204852)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T17:36:50Z","message":"[ES
`body` removal] `@elastic/security-data-analytics`
(#204852)","sha":"a3858a30b21f09527bb3d34e4180db869c60e4cc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ES
`body` removal]
`@elastic/security-data-analytics`","number":204852,"url":"https://github.com/elastic/kibana/pull/204852","mergeCommit":{"message":"[ES
`body` removal] `@elastic/security-data-analytics`
(#204852)","sha":"a3858a30b21f09527bb3d34e4180db869c60e4cc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204852","number":204852,"mergeCommit":{"message":"[ES
`body` removal] `@elastic/security-data-analytics`
(#204852)","sha":"a3858a30b21f09527bb3d34e4180db869c60e4cc"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants