Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES body removal] @elastic/security-detections-response #204879

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 19, 2024

Summary

Attempt to remove the deprecated body in the ES client.

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@afharo afharo self-assigned this Dec 19, 2024
@afharo afharo marked this pull request as ready for review December 19, 2024 11:15
@afharo afharo requested a review from a team as a code owner December 19, 2024 11:15
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo afharo enabled auto-merge (squash) January 10, 2025 15:01
@afharo afharo merged commit baf79bc into elastic:main Jan 10, 2025
9 checks passed
@afharo afharo deleted the esclient/remove-deprecated-body/elastic/security-detections-response branch January 10, 2025 16:58
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12713812208

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2025
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Could not create pull request: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 8841:2F981B:B256B5:1633C7B:678152FA and timestamp 2025-01-10 17:03:54 UTC.

Manual backport

To create the backport manually run:

node scripts/backport --pr 204879

Questions ?

Please refer to the Backport tool documentation

@afharo afharo added backport:skip This commit does not require backporting and removed backport:skip This commit does not require backporting labels Jan 10, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12718945929

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 11, 2025
…s-response` (#204879) (#206360)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES `body` removal]
`@elastic/security-detections-response`
(#204879)](#204879)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T16:58:31Z","message":"[ES
`body` removal] `@elastic/security-detections-response`
(#204879)","sha":"baf79bcd3556b150d1c9e80038d54403ff362181","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ES
`body` removal]
`@elastic/security-detections-response`","number":204879,"url":"https://github.com/elastic/kibana/pull/204879","mergeCommit":{"message":"[ES
`body` removal] `@elastic/security-detections-response`
(#204879)","sha":"baf79bcd3556b150d1c9e80038d54403ff362181"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204879","number":204879,"mergeCommit":{"message":"[ES
`body` removal] `@elastic/security-detections-response`
(#204879)","sha":"baf79bcd3556b150d1c9e80038d54403ff362181"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants