Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX] Use eui font size hook #204903

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[ObsUX] Use eui font size hook #204903

merged 3 commits into from
Dec 19, 2024

Conversation

MiriamAparicio
Copy link
Contributor

Summary

Some font-size were not using the correct hook useEuiFontSize

@MiriamAparicio MiriamAparicio added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team EUI Visual Refresh labels Dec 19, 2024
@MiriamAparicio MiriamAparicio requested review from a team as code owners December 19, 2024 10:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

miloszmarcinkowski
miloszmarcinkowski approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just nits:

.../plugins/observability_solution/apm/public/components/shared/stacktrace/cause_stacktrace.tsx Outdated Show resolved Hide resolved
...ck/plugins/observability_solution/infra/public/components/logging/log_minimap/time_ruler.tsx Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 19, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: dc6c9b5
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204903-dc6c9b540699

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.7MB 5.7MB +16.0B
infra 1.7MB 1.7MB +196.0B
total +212.0B

History

@gbamparop
Copy link
Contributor

/oblt-deploy

gbamparop
gbamparop approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! APM Stacktraces seem to be displayed correctly now.

Screen.Recording.2024-12-19.at.12.35.43.mov

@MiriamAparicio MiriamAparicio merged commit dec31c5 into elastic:main Dec 19, 2024
8 checks passed
@MiriamAparicio MiriamAparicio deleted the fix-font-size-tokens branch December 19, 2024 12:39
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@MiriamAparicio @JoseLuisGJ
[ObsUX] Use eui font size hook (elastic#204903)
9b20917 
## Summary

Some font-size were not using the correct hook `useEuiFontSize`
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@MiriamAparicio @benakansara
[ObsUX] Use eui font size hook (elastic#204903)
f104739 
## Summary

Some font-size were not using the correct hook `useEuiFontSize`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszmarcinkowski miloszmarcinkowski miloszmarcinkowski approved these changes

@gbamparop gbamparop gbamparop approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MiriamAparicio @elasticmachine @gbamparop @crespocarlos @miloszmarcinkowski