Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][threat hunting explore] EUI refresh: Remove color functions #204921

Merged
merged 8 commits into from
Dec 30, 2024
Merged

[Security Solution][threat hunting explore] EUI refresh: Remove color functions #204921

merged 8 commits into from
Dec 30, 2024

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 19, 2024 •
edited
Loading

Summary

#202505

Running Kibana with the Borealis theme

In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start

This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.

Image

@angorayc angorayc mentioned this pull request Dec 19, 2024
Open
mgadewoll
mgadewoll reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Adding an early review due to upcoming PTO

...curity_solution/public/onboarding/components/onboarding_body/onboarding_card_panel.styles.ts Outdated Show resolved Hide resolved
@angorayc angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2024
@angorayc angorayc marked this pull request as ready for review December 19, 2024 17:23
@angorayc angorayc requested review from a team as code owners December 19, 2024 17:23
@angorayc angorayc requested a review from machadoum December 19, 2024 17:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

mgadewoll
mgadewoll approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changes LGTM from EUI side

PhilippeOberti
PhilippeOberti approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desk tested and code LGTM for the Threat Hunting Investigations team, thanks for making these changes!

@angorayc angorayc mentioned this pull request Dec 30, 2024
Merged
@angorayc
Copy link
Contributor Author

angorayc commented Dec 30, 2024 •
edited
Loading

Moved changes for entity analytics to another PR #205262, so explore team's changes can be merged earlier.

@angorayc angorayc enabled auto-merge (squash) December 30, 2024 14:23
angorayc added a commit that referenced this pull request Dec 30, 2024
@angorayc
[Security Solution][Entity Analytics] EUI refresh: Remove color funct…
f349f61 
…ions (#205262)

## Summary

#202505
#204921

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)
@angorayc angorayc merged commit dfeb169 into elastic:main Dec 30, 2024
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB +233.0B

History

stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
@angorayc @stratoula
[Security Solution][Entity Analytics] EUI refresh: Remove color funct…
0eb5c1d 
…ions (elastic#205262)

## Summary

elastic#202505
elastic#204921

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
@angorayc @kibanamachine @stratoula
[Security Solution][threat hunting explore] EUI refresh: Remove color…
3acbb79 
… functions (elastic#204921)

## Summary

elastic#202505

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@angorayc @benakansara
[Security Solution][Entity Analytics] EUI refresh: Remove color funct…
360fcb5 
…ions (elastic#205262)

## Summary

elastic#202505
elastic#204921

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@angorayc @kibanamachine @benakansara
[Security Solution][threat hunting explore] EUI refresh: Remove color…
19a8ace 
… functions (elastic#204921)

## Summary

elastic#202505

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
@angorayc @cqliu1
[Security Solution][Entity Analytics] EUI refresh: Remove color funct…
61aea65 
…ions (elastic#205262)

## Summary

elastic#202505
elastic#204921

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
@angorayc @kibanamachine @cqliu1
[Security Solution][threat hunting explore] EUI refresh: Remove color…
9bfe2c8 
… functions (elastic#204921)

## Summary

elastic#202505

### Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml:
uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn
start

This will expose a toggle under Stack Management > Advanced Settings >
Theme version, which you can use to toggle between Amsterdam and
Borealis.



![Image](https://github.com/user-attachments/assets/78d64946-43fc-4400-bbb1-229d900b7f05)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

@semd semd semd approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@machadoum machadoum Awaiting requested review from machadoum machadoum was automatically assigned from elastic/security-entity-analytics

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@angorayc @elasticmachine @PhilippeOberti @semd @mgadewoll @kibanamachine