OpenAI connector: send default model for "other" openAI provider #204934
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
|
/ci |
|
Pinging @elastic/appex-ai-infra (Team:AI Infra) |
dgieselaar
approved these changes
Dec 23, 2024
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 23, 2024
…stic#204934) ## Summary Part of elastic#204116 When model is not present in the payload, use the default model as specified in the connector configuration. We were already doing that for OpenAI-OpenAI, but not for "Other"-OpenAI. ### Some section because I downloaded ollama just for that issue <img width="950" alt="Screenshot 2024-12-19 at 13 53 48" src="https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8" /> <img width="769" alt="Screenshot 2024-12-19 at 13 54 54" src="https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c" /> (cherry picked from commit d4bc9be)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 23, 2024
…AI provider (#204934) (#205107) # Backport This will backport the following commits from `main` to `8.x`: - [OpenAI connector: send default model for "other" openAI provider (#204934)](#204934) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pierre Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-23T16:16:33Z","message":"OpenAI connector: send default model for \"other\" openAI provider (#204934)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/204116\r\n\r\nWhen model is not present in the payload, use the default model as\r\nspecified in the connector configuration.\r\n\r\nWe were already doing that for OpenAI-OpenAI, but not for\r\n\"Other\"-OpenAI.\r\n\r\n### Some section because I downloaded ollama just for that issue\r\n\r\n<img width=\"950\" alt=\"Screenshot 2024-12-19 at 13 53 48\"\r\nsrc=\"https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8\"\r\n/>\r\n\r\n<img width=\"769\" alt=\"Screenshot 2024-12-19 at 13 54 54\"\r\nsrc=\"https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c\"\r\n/>","sha":"d4bc9befdef02a80545e65507c15780fcf6933f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","Team:AI Infra","v8.18.0"],"title":"OpenAI connector: send default model for \"other\" openAI provider","number":204934,"url":"https://github.com/elastic/kibana/pull/204934","mergeCommit":{"message":"OpenAI connector: send default model for \"other\" openAI provider (#204934)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/204116\r\n\r\nWhen model is not present in the payload, use the default model as\r\nspecified in the connector configuration.\r\n\r\nWe were already doing that for OpenAI-OpenAI, but not for\r\n\"Other\"-OpenAI.\r\n\r\n### Some section because I downloaded ollama just for that issue\r\n\r\n<img width=\"950\" alt=\"Screenshot 2024-12-19 at 13 53 48\"\r\nsrc=\"https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8\"\r\n/>\r\n\r\n<img width=\"769\" alt=\"Screenshot 2024-12-19 at 13 54 54\"\r\nsrc=\"https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c\"\r\n/>","sha":"d4bc9befdef02a80545e65507c15780fcf6933f5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204934","number":204934,"mergeCommit":{"message":"OpenAI connector: send default model for \"other\" openAI provider (#204934)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/204116\r\n\r\nWhen model is not present in the payload, use the default model as\r\nspecified in the connector configuration.\r\n\r\nWe were already doing that for OpenAI-OpenAI, but not for\r\n\"Other\"-OpenAI.\r\n\r\n### Some section because I downloaded ollama just for that issue\r\n\r\n<img width=\"950\" alt=\"Screenshot 2024-12-19 at 13 53 48\"\r\nsrc=\"https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8\"\r\n/>\r\n\r\n<img width=\"769\" alt=\"Screenshot 2024-12-19 at 13 54 54\"\r\nsrc=\"https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c\"\r\n/>","sha":"d4bc9befdef02a80545e65507c15780fcf6933f5"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Pierre Gayvallet <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…stic#204934) ## Summary Part of elastic#204116 When model is not present in the payload, use the default model as specified in the connector configuration. We were already doing that for OpenAI-OpenAI, but not for "Other"-OpenAI. ### Some section because I downloaded ollama just for that issue <img width="950" alt="Screenshot 2024-12-19 at 13 53 48" src="https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8" /> <img width="769" alt="Screenshot 2024-12-19 at 13 54 54" src="https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c" />
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…stic#204934) ## Summary Part of elastic#204116 When model is not present in the payload, use the default model as specified in the connector configuration. We were already doing that for OpenAI-OpenAI, but not for "Other"-OpenAI. ### Some section because I downloaded ollama just for that issue <img width="950" alt="Screenshot 2024-12-19 at 13 53 48" src="https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8" /> <img width="769" alt="Screenshot 2024-12-19 at 13 54 54" src="https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c" />
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…stic#204934) ## Summary Part of elastic#204116 When model is not present in the payload, use the default model as specified in the connector configuration. We were already doing that for OpenAI-OpenAI, but not for "Other"-OpenAI. ### Some section because I downloaded ollama just for that issue <img width="950" alt="Screenshot 2024-12-19 at 13 53 48" src="https://github.com/user-attachments/assets/4a6e4b35-a0c5-46e5-9372-677e99d070f8" /> <img width="769" alt="Screenshot 2024-12-19 at 13 54 54" src="https://github.com/user-attachments/assets/a0a5a12a-ea1e-42b7-8fa1-6531bef5ae6c" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #204116
When model is not present in the payload, use the default model as specified in the connector configuration.
We were already doing that for OpenAI-OpenAI, but not for "Other"-OpenAI.
Some section because I downloaded ollama just for that issue