Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocating module @kbn/index-management-plugin #204953

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Dec 19, 2024

Summary

Last plugin to move for sustainable architecture

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mattkime mattkime marked this pull request as ready for review December 19, 2024 14:21
@mattkime mattkime requested review from a team as code owners December 19, 2024 14:21
@mattkime mattkime self-assigned this Dec 19, 2024
@mattkime mattkime added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2024
@mattkime
Copy link
Contributor Author

/ci

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 19, 2024 14:46
@mattkime
Copy link
Contributor Author

/ci

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm - tested the IM plugin locally and made sure it renders correctly.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / EQL Tab rendering should render the timeline table

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [49f7a8d]

cc @mattkime

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime merged commit 71f2705 into elastic:main Dec 19, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12418779944

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Sustainable Kibana Architecture: Add scripts/relocate CLI (beta) (#203803)

Manual backport

To create the backport manually run:

node scripts/backport --pr 204953

Questions ?

Please refer to the Backport tool documentation

@mattkime
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mattkime added a commit to mattkime/kibana that referenced this pull request Dec 19, 2024
## Summary

Last plugin to move for sustainable architecture

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 71f2705)

# Conflicts:
#	.github/CODEOWNERS
mattkime added a commit that referenced this pull request Dec 20, 2024
…5025)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Relocating module `@kbn/index-management-plugin`
(#204953)](#204953)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T18:39:27Z","message":"Relocating
module `@kbn/index-management-plugin` (#204953)\n\n##
Summary\r\n\r\nLast plugin to move for sustainable
architecture\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"71f27053c89ed8ce97ac1dc8f478e928cceedb90","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"number":204953,"url":"https://github.com/elastic/kibana/pull/204953","mergeCommit":{"message":"Relocating
module `@kbn/index-management-plugin` (#204953)\n\n##
Summary\r\n\r\nLast plugin to move for sustainable
architecture\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"71f27053c89ed8ce97ac1dc8f478e928cceedb90"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204953","number":204953,"mergeCommit":{"message":"Relocating
module `@kbn/index-management-plugin` (#204953)\n\n##
Summary\r\n\r\nLast plugin to move for sustainable
architecture\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"71f27053c89ed8ce97ac1dc8f478e928cceedb90"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
## Summary

Last plugin to move for sustainable architecture

---------

Co-authored-by: kibanamachine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
## Summary

Last plugin to move for sustainable architecture

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants