[Upgrade Assistant] Reindexing optimizations #205055
Open
+256
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @afharo |
jloleysens
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Tested locally and this works as expected. Great work @afharo , I think you covered everything. Left a minor comment about a test case.
| }); | ||
|
|
||
| if (!settingsResponse.acknowledged) { | ||
| throw error.cannotCreateIndex(`The original index settings could not be restored.`); |
There was a problem hiding this comment.
Is it possible to include some more info from the settingsResponse in this case? Could be useful for debugging in future scenarios.
|
|
||
| // The new index was created | ||
| expect(indexSummary[newIndexName]).to.be.an('object'); | ||
| // The original index name is aliased to the new one | ||
| expect(indexSummary[newIndexName].aliases?.dummydata).to.be.an('object'); | ||
| // Verify mappings exist on new index | ||
| expect(indexSummary[newIndexName].mappings?.properties).to.be.an('object'); | ||
| // Verify settings exist on new index | ||
| expect(indexSummary[newIndexName].settings).to.be.an('object'); | ||
| expect({ |
There was a problem hiding this comment.
Did this archive have an index with non-default settings? Would be nice to have a test case with default settings and one with explicit settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade assistant sets recommended index settings for faster reindexing operations, and reverts them after completion.
Resolves #201605.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.