[code-owners] Add area information to code owner entries #205143
Merged
+119
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a simple mapping mechanism between owners and areas of the Elastic organisation. Mappings have been defined statically in `packages/kbn-code-owners/src/code_owner_areas.ts`. The new area information has been added to `CodeOwnersEntry` objects. The `scripts/get_owners_for_file` script has been updated to display area information.
dolaru
added
release_note:skip
fake-haris
approved these changes
Dec 24, 2024
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
cc @dolaru |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 24, 2024
) (cherry picked from commit fa1655e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 24, 2024
…) (#205147) # Backport This will backport the following commits from `main` to `8.x`: - [[code-owners] Add area information to code owner entries (#205143)](#205143) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Olaru","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-24T16:21:11Z","message":"[code-owners] Add area information to code owner entries (#205143)","sha":"fa1655e418db9fb5503d5b3ac88f57ffa7a7a061","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"[code-owners] Add area information to code owner entries","number":205143,"url":"https://github.com/elastic/kibana/pull/205143","mergeCommit":{"message":"[code-owners] Add area information to code owner entries (#205143)","sha":"fa1655e418db9fb5503d5b3ac88f57ffa7a7a061"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205143","number":205143,"mergeCommit":{"message":"[code-owners] Add area information to code owner entries (#205143)","sha":"fa1655e418db9fb5503d5b3ac88f57ffa7a7a061"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: David Olaru <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a simple mapping mechanism between owners and areas of the Elastic organisation.
Mappings have been defined statically in
packages/kbn-code-owners/src/code_owner_areas.ts.The new area information has been added to
CodeOwnersEntryobjects.The
scripts/get_owners_for_filescript has been updated to display area information.