Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Cloud Security] Improve graph component performance (#204983) #205148

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Apply some graph optimizations and added the first graph benchmark
storybook.

You can read the detailed investigation process
[here](elastic#204982 (comment)).

I kept the dashed lines until a new design will be introduced.

Before:

https://github.com/user-attachments/assets/145a82c0-dbd0-410f-a451-eaa8adcc931b

After:

https://github.com/user-attachments/assets/3c13cae5-85d2-481b-8fc6-cec08ecee0d9

**How to test this PR**

To test this PR you can run

```
yarn storybook cloud_security_posture_packages
```

Or open the storybook link attached to the build message

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit d5fe929)
@kibanamachine kibanamachine merged commit 91b6a29 into elastic:8.x Dec 24, 2024
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6469 6470 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cloud-security-posture-graph 19 18 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.5MB 18.5MB +297.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/cloud-security-posture-graph 16 21 +5

Total ESLint disabled count

id before after diff
@kbn/cloud-security-posture-graph 18 23 +5

cc @kfirpeled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants