fix(codeql): update CodeQL ingore-paths config
#205197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
azasypkin
commented
Dec 27, 2024
Comment on lines
+91
to
+93
| - x-pack/platform/**/scripts | ||
| - x-pack/scripts | ||
| - x-pack/solutions/**/scripts |
There was a problem hiding this comment.
Important
These patterns are somewhat risky and might potentially include some real production code. However, the risk is very low, and the number of false positives we get from scripts is high. Let’s proceed with this approach and only make adjustments if we discover that something important is being skipped.
elena-shostak
approved these changes
Dec 27, 2024
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 27, 2024
## Summary This PR updates `ignore-paths` path CodeQL config to remove the paths that no longer exist and exclude other well-known test/dev-only paths. Non-existent paths can be seen in the CodeQL logs from the most recent run: ``` 2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist. 2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist. 2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist. 2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist. 2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist. 2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist. ``` (cherry picked from commit 04ff8aa)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Dec 27, 2024
## Summary This PR updates `ignore-paths` path CodeQL config to remove the paths that no longer exist and exclude other well-known test/dev-only paths. Non-existent paths can be seen in the CodeQL logs from the most recent run: ``` 2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist. 2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist. 2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist. 2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist. 2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist. 2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist. ``` (cherry picked from commit 04ff8aa) # Conflicts: # .github/codeql/codeql-config.yml
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
azasypkin
added
v8.18.0
v7.17.27
and removed
backport:all-open
kibanamachine
added a commit
that referenced
this pull request
Dec 27, 2024
…5197) (#205202) # Backport This will backport the following commits from `main` to `8.x`: - [fix(codeql): update CodeQL `ingore-paths` config (#205197)](#205197) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-27T12:58:15Z","message":"fix(codeql): update CodeQL `ingore-paths` config (#205197)\n\n## Summary\n\nThis PR updates `ignore-paths` path CodeQL config to remove the paths\nthat no longer exist and exclude other well-known test/dev-only paths.\n\nNon-existent paths can be seen in the CodeQL logs from the most recent\nrun:\n```\n2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist.\n2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist.\n2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist.\n2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist.\n2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist.\n2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist.\n```","sha":"04ff8aafe599f929710069ff75e12bfdd4d67ce2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","v9.0.0","backport:all-open"],"title":"fix(codeql): update CodeQL `ingore-paths` config","number":205197,"url":"https://github.com/elastic/kibana/pull/205197","mergeCommit":{"message":"fix(codeql): update CodeQL `ingore-paths` config (#205197)\n\n## Summary\n\nThis PR updates `ignore-paths` path CodeQL config to remove the paths\nthat no longer exist and exclude other well-known test/dev-only paths.\n\nNon-existent paths can be seen in the CodeQL logs from the most recent\nrun:\n```\n2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist.\n2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist.\n2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist.\n2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist.\n2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist.\n2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist.\n```","sha":"04ff8aafe599f929710069ff75e12bfdd4d67ce2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205197","number":205197,"mergeCommit":{"message":"fix(codeql): update CodeQL `ingore-paths` config (#205197)\n\n## Summary\n\nThis PR updates `ignore-paths` path CodeQL config to remove the paths\nthat no longer exist and exclude other well-known test/dev-only paths.\n\nNon-existent paths can be seen in the CodeQL logs from the most recent\nrun:\n```\n2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist.\n2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist.\n2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist.\n2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist.\n2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist.\n2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist.\n```","sha":"04ff8aafe599f929710069ff75e12bfdd4d67ce2"}}]}] BACKPORT--> Co-authored-by: Aleh Zasypkin <[email protected]>
azasypkin
added a commit
that referenced
this pull request
Dec 27, 2024
…05203) # Backport This will backport the following commits from `main` to `7.17`: - [fix(codeql): update CodeQL `ingore-paths` config (#205197)](#205197) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-27T12:58:15Z","message":"fix(codeql): update CodeQL `ingore-paths` config (#205197)\n\n## Summary\n\nThis PR updates `ignore-paths` path CodeQL config to remove the paths\nthat no longer exist and exclude other well-known test/dev-only paths.\n\nNon-existent paths can be seen in the CodeQL logs from the most recent\nrun:\n```\n2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist.\n2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist.\n2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist.\n2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist.\n2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist.\n2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist.\n```","sha":"04ff8aafe599f929710069ff75e12bfdd4d67ce2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","v9.0.0","backport:all-open"],"number":205197,"url":"https://github.com/elastic/kibana/pull/205197","mergeCommit":{"message":"fix(codeql): update CodeQL `ingore-paths` config (#205197)\n\n## Summary\n\nThis PR updates `ignore-paths` path CodeQL config to remove the paths\nthat no longer exist and exclude other well-known test/dev-only paths.\n\nNon-existent paths can be seen in the CodeQL logs from the most recent\nrun:\n```\n2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist.\n2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist.\n2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist.\n2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist.\n2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist.\n2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist.\n```","sha":"04ff8aafe599f929710069ff75e12bfdd4d67ce2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205197","number":205197,"mergeCommit":{"message":"fix(codeql): update CodeQL `ingore-paths` config (#205197)\n\n## Summary\n\nThis PR updates `ignore-paths` path CodeQL config to remove the paths\nthat no longer exist and exclude other well-known test/dev-only paths.\n\nNon-existent paths can be seen in the CodeQL logs from the most recent\nrun:\n```\n2024-12-26T21:29:09.2376056Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-babel-plugin-package-imports, which does not exist.\n2024-12-26T21:29:09.2377637Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-bazel-packages, which does not exist.\n2024-12-26T21:29:09.2387717Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-package-map, which does not exist.\n2024-12-26T21:29:09.2390381Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-spec-to-console, which does not exist.\n2024-12-26T21:29:09.2396606Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter, which does not exist.\n2024-12-26T21:29:09.2402596Z [2024-12-26 21:29:09] [build-stderr] Skipping path /home/runner/work/kibana/kibana/packages/kbn-ts-project-linter-cli, which does not exist.\n```","sha":"04ff8aafe599f929710069ff75e12bfdd4d67ce2"}},{"url":"https://github.com/elastic/kibana/pull/205202","number":205202,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
This was referenced Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
ignore-pathspath CodeQL config to remove the paths that no longer exist and exclude other well-known test/dev-only paths.Non-existent paths can be seen in the CodeQL logs from the most recent run: