Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Add route privilege tests for Serverless #205210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

viduni94
Copy link
Contributor

Summary

This PR adds security and route privilege tests to the serverless test suite.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 added release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v8.18.0 labels Dec 27, 2024
@viduni94 viduni94 self-assigned this Dec 27, 2024
@viduni94 viduni94 requested a review from a team as a code owner December 27, 2024 15:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 linked an issue Dec 27, 2024 that may be closed by this pull request
@viduni94 viduni94 force-pushed the add-route-privilege-tests-to-serverless branch from ed525be to c085431 Compare December 27, 2024 15:15
@@ -170,57 +172,26 @@ export default function ApiTest({ getService }: FtrProviderContext) {
]);
});

it.skip('returns a useful error if the request fails', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we skip this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was skipped as part of the migration to inference endpoints. The discussion thread can be found here - https://github.com/elastic/kibana/pull/199286/files#r1867485436

@viduni94 viduni94 force-pushed the add-route-privilege-tests-to-serverless branch from c085431 to 8852cdc Compare December 30, 2024 13:50
@viduni94 viduni94 requested a review from dgieselaar December 30, 2024 14:18
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @viduni94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Route access privilege tests for serverless
3 participants