-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Expand rule upgrade review functionality test plan and coverage to include all rule fields #205217
base: main
Are you sure you want to change the base?
[Security Solution] Expand rule upgrade review functionality test plan and coverage to include all rule fields #205217
Conversation
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7636[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/ess.config.ts: 74/100 tests passed. |
💚 Build Succeeded
Metrics [docs]
History
cc @jpdjere |
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Partially resolves: #202078
Summary
/upgrade/_review
endpoint) test plan and coverage to include all diffable fields:upgrade.md
test plan to list all diffable fields that should be testedupgrade_review_prebuilt_rules.[ALGORITHM]_fields.ts
integration test suites to actually test reviewing upgrades for all possible diffable fields.upgrade_review_prebuilt_rules.simple_fields.ts
for testing fields which still have the simple diff algorithm, which was missing.Flaky test run
🕐 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7636
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*
label is applied per the guidelines