Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][THI] - replace usages of EUI vis colors #205218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security Solution][THI] - replace usages of EUI vis colors #205218

wants to merge 1 commit into from
+62 −101

Conversation

PhilippeOberti
Copy link
Contributor

Summary

This PR is part of a list of PRs to performt eh changes necessary to get the new Borealis theme working correctly. It focuses on replace the vis colors for non-visualization usages by correct EUI color tokens.

2 places have been impacted:

  • the alerts data table in grouping mode (for host, user, rule and network)

Host

before after
data-table-host-main data-table-host-new

User

before after
data-table-user-main data-table-user-new

Rule

before after
data-table-rule-main data-table-rule-new

Network

before after
data-table-network-main data-table-network-new
  • the dataprovider badge in timeline

Dark mode

before after
timeline-main-dark timeline-new-dark

Light mode

before after
timeline-main-light timeline-new-light

#201883

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Threat Hunting:Investigations Security Solution Investigations Team EUI Visual Refresh labels Dec 27, 2024
@PhilippeOberti PhilippeOberti requested review from a team as code owners December 27, 2024 19:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

angorayc
angorayc reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that we no longer have background color of the group icons after migration, is it intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilippeOberti @elasticmachine @angorayc