Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] folder cleanup #205219

Merged
merged 9 commits into from
Jan 7, 2025
Merged

[embeddable] folder cleanup #205219

merged 9 commits into from
Jan 7, 2025
+85 −175

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 27, 2024 •
edited by kibanamachine
Loading

Clean up embeddable folder structure.

PR also splits COMMON_EMBEDDABLE_GROUPING into ADD_PANEL_ANNOTATION_GROUP, ADD_PANEL_LEGACY_GROUP, and ADD_PANEL_OTHER_GROUP to provide a more contextually relevant name.

@nreese
Copy link
Contributor Author

nreese commented Dec 27, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 27, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 27, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 2, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 2, 2025

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 86 84 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 152 145 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 666.6KB 666.5KB -48.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 22.5KB 22.6KB +163.0B
imageEmbeddable 5.8KB 5.8KB -11.0B
links 16.7KB 16.7KB -11.0B
visualizations 62.6KB 62.6KB -11.0B
total +130.0B
Unknown metric groups

API count

id before after diff
embeddable 179 172 -7

ESLint disabled in files

id before after diff
embeddable 1 0 -1

Total ESLint disabled count

id before after diff
embeddable 2 1 -1

History

@nreese nreese marked this pull request as ready for review January 2, 2025 22:03
@nreese nreese requested review from a team as code owners January 2, 2025 22:03
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Jan 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson
ThomThomson approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File renames and moves LGTM! Is there any way we could fit the new file add_panel_groups into a folder so it isn't top level? Maybe rename triggers to ui_actions and put it in there?

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 3, 2025
ppisljar
ppisljar approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vis team changes lgtm

eokoneyo
eokoneyo approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM, did not test locally.

@nreese nreese merged commit fd702ef into elastic:main Jan 7, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12656229994

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
@nreese
[embeddable] folder cleanup (elastic#205219)
3f685d1 
Clean up embeddable folder structure.

PR also splits `COMMON_EMBEDDABLE_GROUPING` into
`ADD_PANEL_ANNOTATION_GROUP`, `ADD_PANEL_LEGACY_GROUP`, and
`ADD_PANEL_OTHER_GROUP` to provide a more contextually relevant name.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit fd702ef)
@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Open
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@nreese nreese mentioned this pull request Jan 7, 2025
Open
@nreese
Copy link
Contributor Author

nreese commented Jan 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nreese added a commit to nreese/kibana that referenced this pull request Jan 7, 2025
@nreese
[embeddable] folder cleanup (elastic#205219)
3ae450b 
Clean up embeddable folder structure.

PR also splits `COMMON_EMBEDDABLE_GROUPING` into
`ADD_PANEL_ANNOTATION_GROUP`, `ADD_PANEL_LEGACY_GROUP`, and
`ADD_PANEL_OTHER_GROUP` to provide a more contextually relevant name.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit fd702ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@ppisljar ppisljar ppisljar approved these changes

@eokoneyo eokoneyo eokoneyo approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nreese @elasticmachine @kibanamachine @eokoneyo @ppisljar @ThomThomson