Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [embeddable] folder cleanup (#205219) #205801

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[8.x] [embeddable] folder cleanup (#205219) #205801

merged 2 commits into from
Jan 7, 2025

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 7, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[embeddable] folder cleanup (elastic#205219)
3ae450b 
Clean up embeddable folder structure.

PR also splits `COMMON_EMBEDDABLE_GROUPING` into
`ADD_PANEL_ANNOTATION_GROUP`, `ADD_PANEL_LEGACY_GROUP`, and
`ADD_PANEL_OTHER_GROUP` to provide a more contextually relevant name.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit fd702ef)
@nreese nreese requested a review from kibanamachine as a code owner January 7, 2025 18:54
@nreese nreese added the backport label Jan 7, 2025
@nreese nreese enabled auto-merge (squash) January 7, 2025 18:54
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 7, 2025
@nreese nreese mentioned this pull request Jan 7, 2025
Merged
@nreese nreese mentioned this pull request Jan 7, 2025
Closed
@nreese nreese merged commit 0e61848 into elastic:8.x Jan 7, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 86 84 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 152 145 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 631.0KB 631.0KB -48.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 22.5KB 22.6KB +163.0B
imageEmbeddable 5.8KB 5.8KB -11.0B
infra 56.0KB 56.0KB -11.0B
links 16.7KB 16.7KB -11.0B
visualizations 62.6KB 62.6KB -11.0B
total +119.0B
Unknown metric groups

API count

id before after diff
embeddable 179 172 -7

ESLint disabled in files

id before after diff
embeddable 1 0 -1

Total ESLint disabled count

id before after diff
embeddable 2 1 -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @elasticmachine @nickpeihl