[8.x] backport "Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-logs-team`" #205234

pgayvallet · 2024-12-30T08:46:14Z

Manual backport of #202831 by rerunning the script against 8.x

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Any manual contributions will be lost if the 'relocate' script is re-run.
Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

9 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/data-quality-plugin`	`x-pack/platform/plugins/shared/data_quality`
`@kbn/dataset-quality-plugin`	`x-pack/platform/plugins/shared/observability_solution/dataset_quality`
`@kbn/fields-metadata-plugin`	`x-pack/platform/plugins/shared/fields_metadata`
`@kbn/infra-plugin`	`x-pack/solutions/observability/plugins/infra`
`@kbn/logs-data-access-plugin`	`x-pack/platform/plugins/shared/observability_solution/logs_data_access`
`@kbn/logs-explorer-plugin`	`x-pack/solutions/observability/plugins/logs_explorer`
`@kbn/logs-shared-plugin`	`x-pack/platform/plugins/shared/observability_solution/logs_shared`
`@kbn/observability-logs-explorer-plugin`	`x-pack/solutions/observability/plugins/observability_logs_explorer`
`@kbn/observability-onboarding-plugin`	`x-pack/solutions/observability/plugins/observability_onboarding`

9 packages(s) are going to be relocated:

Id	Target folder
`@kbn/custom-icons`	`src/platform/packages/shared/kbn-custom-icons`
`@kbn/custom-integrations`	`x-pack/solutions/observability/packages/kbn-custom-integrations`
`@kbn/discover-contextual-components`	`src/platform/packages/shared/kbn-discover-contextual-components`
`@kbn/elastic-agent-utils`	`src/platform/packages/shared/kbn-elastic-agent-utils`
`@kbn/observability-logs-overview`	`x-pack/platform/packages/shared/observability/logs_overview`
`@kbn/react-hooks`	`src/platform/packages/shared/kbn-react-hooks`
`@kbn/router-utils`	`src/platform/packages/shared/kbn-router-utils`
`@kbn/timerange`	`src/platform/packages/shared/kbn-timerange`
`@kbn/xstate-utils`	`src/platform/packages/shared/kbn-xstate-utils`

Updated relative paths

src/platform/packages/shared/kbn-custom-icons/jest.config.js:12
src/platform/packages/shared/kbn-custom-icons/tsconfig.json:2
src/platform/packages/shared/kbn-discover-contextual-components/jest.config.js:12
src/platform/packages/shared/kbn-discover-contextual-components/tsconfig.json:2
src/platform/packages/shared/kbn-elastic-agent-utils/jest.config.js:12
src/platform/packages/shared/kbn-elastic-agent-utils/tsconfig.json:2
src/platform/packages/shared/kbn-react-hooks/jest.config.js:12
src/platform/packages/shared/kbn-react-hooks/tsconfig.json:2
src/platform/packages/shared/kbn-router-utils/jest.config.js:12
src/platform/packages/shared/kbn-router-utils/tsconfig.json:2
src/platform/packages/shared/kbn-timerange/jest.config.js:12
src/platform/packages/shared/kbn-timerange/tsconfig.json:2
src/platform/packages/shared/kbn-xstate-utils/jest.config.js:12
src/platform/packages/shared/kbn-xstate-utils/tsconfig.json:2
x-pack/platform/packages/shared/observability/logs_overview/jest.config.js:10
x-pack/platform/packages/shared/observability/logs_overview/tsconfig.json:2
x-pack/platform/plugins/shared/data_quality/jest.config.js:10
x-pack/platform/plugins/shared/data_quality/tsconfig.json:11
x-pack/platform/plugins/shared/data_quality/tsconfig.json:2
x-pack/platform/plugins/shared/fields_metadata/jest.config.js:10
x-pack/platform/plugins/shared/fields_metadata/tsconfig.json:2
x-pack/platform/plugins/shared/fields_metadata/tsconfig.json:7
x-pack/platform/plugins/shared/observability_solution/dataset_quality/jest.config.js:10
x-pack/platform/plugins/shared/observability_solution/dataset_quality/tsconfig.json:10
x-pack/platform/plugins/shared/observability_solution/dataset_quality/tsconfig.json:2
x-pack/platform/plugins/shared/observability_solution/logs_data_access/jest.config.js:12
x-pack/platform/plugins/shared/observability_solution/logs_data_access/tsconfig.json:2
x-pack/platform/plugins/shared/observability_solution/logs_shared/jest.config.js:10
x-pack/platform/plugins/shared/observability_solution/logs_shared/public/components/log_stream/log_stream.stories.mdx:12
x-pack/platform/plugins/shared/observability_solution/logs_shared/tsconfig.json:2
x-pack/platform/plugins/shared/observability_solution/logs_shared/tsconfig.json:7
x-pack/solutions/observability/packages/kbn-custom-integrations/jest.config.js:12
x-pack/solutions/observability/packages/kbn-custom-integrations/tsconfig.json:2
x-pack/solutions/observability/plugins/infra/README.md:121
x-pack/solutions/observability/plugins/infra/README.md:29
x-pack/solutions/observability/plugins/infra/docs/telemetry/define_custom_events.md:18
x-pack/solutions/observability/plugins/infra/jest.config.js:10
x-pack/solutions/observability/plugins/infra/tsconfig.json:2
x-pack/solutions/observability/plugins/infra/tsconfig.json:7
x-pack/solutions/observability/plugins/logs_explorer/jest.config.js:10
x-pack/solutions/observability/plugins/logs_explorer/tsconfig.json:2
x-pack/solutions/observability/plugins/logs_explorer/tsconfig.json:7
x-pack/solutions/observability/plugins/observability_logs_explorer/jest.config.js:10
x-pack/solutions/observability/plugins/observability_logs_explorer/tsconfig.json:2
x-pack/solutions/observability/plugins/observability_logs_explorer/tsconfig.json:7
x-pack/solutions/observability/plugins/observability_onboarding/e2e/README.md:3
x-pack/solutions/observability/plugins/observability_onboarding/e2e/tsconfig.json:11
x-pack/solutions/observability/plugins/observability_onboarding/e2e/tsconfig.json:2
x-pack/solutions/observability/plugins/observability_onboarding/jest.config.js:12
x-pack/solutions/observability/plugins/observability_onboarding/tsconfig.json:2
x-pack/solutions/observability/plugins/observability_onboarding/tsconfig.json:7

github-actions · 2024-12-30T08:46:27Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

pgayvallet · 2024-12-30T08:46:44Z

/ci

…-fix'

gbamparop · 2024-12-30T09:42:04Z

@pgayvallet just mentioning it because of the PR's title, this targets plugins owned by the @elastic/obs-ux-logs-team, not @elastic/kibana-data-discovery

elasticmachine · 2024-12-30T11:16:57Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #11 / Cloud Security Posture Findings Page onboarding Vulnerabilities - clicking on the No integrations installed prompt action button - install CNVM: navigates to the CNVM integration installation page
[job] [logs] FTR Configs #45 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Bootstrap Prebuilt Rules should install fleet packages required for detection engine to function

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.7MB	1.7MB	-2.0B
`logsExplorer`	223.0KB	223.0KB	+2.0B
`observabilityLogsExplorer`	148.2KB	148.2KB	+1.0B
total			+1.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`infra`	42	40	-2
`logsExplorer`	6	4	-2
`logsShared`	18	17	-1
`observabilityOnboarding`	13	7	-6
total			-11

Total ESLint disabled count

id	before	after	diff
`infra`	51	49	-2
`logsExplorer`	8	6	-2
`logsShared`	21	20	-1
`observabilityOnboarding`	18	12	-6
total			-11

History

💔 Build #263269 failed 77b7090

pgayvallet · 2024-12-30T12:05:48Z

@gbamparop

just mentioning it because of the PR's title, this targets plugins owned by the @elastic/obs-ux-logs-team, not @elastic/kibana-data-discovery

Woups 😅 thanks,, fixed

pgayvallet added 18 commits December 30, 2024 09:17

Relocating module @kbn/custom-icons

2b7c5d0

Relocating module @kbn/custom-integrations

4823152

Relocating module @kbn/data-quality-plugin

f1f7600

Relocating module @kbn/dataset-quality-plugin

d17facd

Relocating module @kbn/discover-contextual-components

5b268bf

Relocating module @kbn/elastic-agent-utils

d8af429

Relocating module @kbn/fields-metadata-plugin

2225255

Relocating module @kbn/infra-plugin

594af30

Relocating module @kbn/logs-data-access-plugin

78f076f

Relocating module @kbn/logs-explorer-plugin

23e36f4

Relocating module @kbn/logs-shared-plugin

b930946

Relocating module @kbn/observability-logs-explorer-plugin

0d1d86e

Relocating module @kbn/observability-logs-overview

dcce22c

Relocating module @kbn/observability-onboarding-plugin

372b535

Relocating module @kbn/react-hooks

10458f4

Relocating module @kbn/router-utils

6f07f74

Relocating module @kbn/timerange

be8cac0

Relocating module @kbn/xstate-utils

77b7090

pgayvallet changed the title ~~<title>~~ [8.x] backport "Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-data-discovery" Dec 30, 2024

pgayvallet mentioned this pull request Dec 30, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-logs-team #202831

Merged

pgayvallet added the backport label Dec 30, 2024

pgayvallet marked this pull request as ready for review December 30, 2024 08:48

pgayvallet requested a review from kibanamachine as a code owner December 30, 2024 08:48

gsoldevila approved these changes Dec 30, 2024

View reviewed changes

pgayvallet and others added 2 commits December 30, 2024 10:11

update telemetry mapping files

c9da254

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

b285059

…-fix'

pgayvallet changed the title ~~[8.x] backport "Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-data-discovery"~~ [8.x] backport "Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-logs-team" Dec 30, 2024

pgayvallet merged commit 5d84355 into elastic:8.x Dec 30, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.x] backport "Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-logs-team`" #205234

[8.x] backport "Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-logs-team`" #205234

pgayvallet commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024

pgayvallet commented Dec 30, 2024

gbamparop commented Dec 30, 2024

elasticmachine commented Dec 30, 2024

ESLint disabled line counts

Total ESLint disabled count

pgayvallet commented Dec 30, 2024

[8.x] backport "Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-logs-team" #205234

[8.x] backport "Sustainable Kibana Architecture: Move modules owned by @elastic/obs-ux-logs-team" #205234

Conversation

pgayvallet commented Dec 30, 2024 • edited Loading

Summary

9 plugin(s) are going to be relocated:

9 packages(s) are going to be relocated:

github-actions bot commented Dec 30, 2024

pgayvallet commented Dec 30, 2024

gbamparop commented Dec 30, 2024

elasticmachine commented Dec 30, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

pgayvallet commented Dec 30, 2024

[8.x] backport "Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-logs-team`" #205234

[8.x] backport "Sustainable Kibana Architecture: Move modules owned by `@elastic/obs-ux-logs-team`" #205234

pgayvallet commented Dec 30, 2024 •

edited

Loading