-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Streams] Schema Editor isWiredStream > isWiredReadStream #205251
Merged
Kerry350
merged 1 commit into
elastic:main
from
Kerry350:fix-schema-editor-to-match-api
Dec 30, 2024
Merged
[Streams] Schema Editor isWiredStream > isWiredReadStream #205251
Kerry350
merged 1 commit into
elastic:main
from
Kerry350:fix-schema-editor-to-match-api
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
backport:version
Backport to applied version labels
v8.18.0
Feature:Streams
This is the label for the Streams Project
labels
Dec 30, 2024
tonyghiani
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the same issues while working on my PR for the enrichment, thanks for the fix!
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 30, 2024
…5251) ## Summary Small fix to the Schema Editor page after the changes in elastic#204671. (Without this mapped fields won't be displayed as we use a read stream definition). (cherry picked from commit 8cc2f2b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 30, 2024
…205251) (#205266) # Backport This will backport the following commits from `main` to `8.x`: - [[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)](#205251) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T14:24:19Z","message":"[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n## Summary\r\n\r\nSmall fix to the Schema Editor page after the changes in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without this mapped fields won't be displayed as we use a read stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"title":"[Streams] Schema Editor isWiredStream > isWiredReadStream","number":205251,"url":"https://github.com/elastic/kibana/pull/205251","mergeCommit":{"message":"[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n## Summary\r\n\r\nSmall fix to the Schema Editor page after the changes in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without this mapped fields won't be displayed as we use a read stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205251","number":205251,"mergeCommit":{"message":"[Streams] Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n## Summary\r\n\r\nSmall fix to the Schema Editor page after the changes in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without this mapped fields won't be displayed as we use a read stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…5251) ## Summary Small fix to the Schema Editor page after the changes in elastic#204671. (Without this mapped fields won't be displayed as we use a read stream definition).
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…5251) ## Summary Small fix to the Schema Editor page after the changes in elastic#204671. (Without this mapped fields won't be displayed as we use a read stream definition).
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
…5251) ## Summary Small fix to the Schema Editor page after the changes in elastic#204671. (Without this mapped fields won't be displayed as we use a read stream definition).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:Streams
This is the label for the Streams Project
release_note:skip
Skip the PR/issue when compiling release notes
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small fix to the Schema Editor page after the changes in #204671.
(Without this mapped fields won't be displayed as we use a read stream definition).