[8.x] Gracefully disable favorites if profile is not available (#204397) #205270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ## Summary When a user profile is not available, the favorites (starred) service can't be used. On UI user profile can be not available if security is disabled or for an anonymous user. This PR improves the handling of starred features for rare cases when a profile is missing: - No unnecessary `GET favorites` requests that would fail with error and add noise to console/networks - No unhandled errors are thrown - Starred tab in esql is hidden - The Dashboard Starred tab isn't flickering on each attempt to fetch favorites For this needed to expose `userProfile.enabled$` from core, also created elastic#204570 ### Testing ``` node scripts/functional_tests_server.js --config test/functional/apps/dashboard/group4/config.ts localhost:5620 ``` another way is by configuring an anonymous user https://www.elastic.co/guide/en/elasticsearch/reference/current/anonymous-access.html (cherry picked from commit 70cf414)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation
Questions ?
Please refer to the Backport tool documentation
Questions ?
Please refer to the Backport tool documentation
Questions ?
Please refer to the Backport tool documentation