Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] Remove filtering out of dot prefixed index patterns #205276

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kertal
Copy link
Member

@kertal kertal commented Dec 30, 2024

Summary

A quick POC to filter out dot prefixed alias indices like in the following screenshot by @stratoula

image

Note that it would be better to fix those indices to be hidden, if this is intended.

With the simple change of this PR, non-hidden but . prefixed indices are suggested by the autocomplete of the ES|QL editor:

CleanShot 2024-12-30 at 18 19 41

This can be tested here:
https://kertal-pr-205276-discover-esql-make-use-of-dot-prefixed-ind.kbndev.co/app/r/s/vFXr6

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@kertal
Copy link
Member Author

kertal commented Dec 30, 2024

/ci

@kertal kertal self-assigned this Dec 30, 2024
@kertal
Copy link
Member Author

kertal commented Dec 30, 2024

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 666.3KB 666.3KB +45.0B
esql 202.6KB 202.6KB +94.0B
lens 1.5MB 1.5MB +45.0B
total +184.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 45.2KB 45.2KB +45.0B

cc @kertal

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx Matthias for taking the time to look into this but I dont want to procced like this

  • it is covering even more the problem
  • the logic should not be added in the ES|QL editor

The correct approach is to do an audit to our indexes and mark them as hidden when we dont want to. This is very important as with this way the FROM * wont query them. I have already said the same to Nino and Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants