Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text #205336

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 31, 2024

Closes: #204483

Related to: #188075

Description

A similar issue was already fixed in #188075. To address #204483, we just need to restore the name from the fetchRulesSnoozeSettings request.

Screen

image

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:skip Skip the PR/issue when compiling release notes labels Dec 31, 2024
@alexwizp
Copy link
Contributor Author

/ci

1 similar comment
@alexwizp
Copy link
Contributor Author

alexwizp commented Jan 2, 2025

/ci

@alexwizp alexwizp marked this pull request as ready for review January 2, 2025 13:36
@alexwizp alexwizp requested a review from a team as a code owner January 2, 2025 13:36
@alexwizp alexwizp requested a review from xcrzx January 2, 2025 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👍

@alexwizp alexwizp enabled auto-merge (squash) January 6, 2025 11:14
@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / Serverless Common UI - Management Search bar features list features has the correct features enabled

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [e04b200]

History

…rules table on Detection rules(siem) page is missing accessible discernible text

Closes: elastic#205336
@alexwizp alexwizp merged commit eafa15b into elastic:main Jan 6, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12636218667

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 6, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit eafa15b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 6, 2025
…alled rules table on Detection rules(siem) page is missing accessible discernible text (#205336) (#205629)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Rules:Detection Rules]Notify Bell button on installed
rules table on Detection rules(siem) page is missing accessible
discernible text
(#205336)](#205336)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T16:24:20Z","message":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text (#205336)\n\nCloses: #204483\r\n\r\nRelated to:
https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description
\r\n\r\nA similar issue was already fixed
in\r\nhttps://github.com//pull/188075. To address #204483,
we\r\njust need to restore the name from the fetchRulesSnoozeSettings
request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor"],"title":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text","number":205336,"url":"https://github.com/elastic/kibana/pull/205336","mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text (#205336)\n\nCloses: #204483\r\n\r\nRelated to:
https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description
\r\n\r\nA similar issue was already fixed
in\r\nhttps://github.com//pull/188075. To address #204483,
we\r\njust need to restore the name from the fetchRulesSnoozeSettings
request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205336","number":205336,"mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text (#205336)\n\nCloses: #204483\r\n\r\nRelated to:
https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description
\r\n\r\nA similar issue was already fixed
in\r\nhttps://github.com//pull/188075. To address #204483,
we\r\njust need to restore the name from the fetchRulesSnoozeSettings
request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description 

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description 

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description 

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
4 participants