-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text #205336
Conversation
/ci |
/ci |
1 similar comment
/ci |
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM 👍
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
|
…rules table on Detection rules(siem) page is missing accessible discernible text Closes: elastic#205336
Starting backport for target branches: 8.x |
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336) Closes: elastic#204483 Related to: elastic#188075 ## Description A similar issue was already fixed in elastic#188075. To address elastic#204483, we just need to restore the name from the fetchRulesSnoozeSettings request. ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6" /> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit eafa15b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…alled rules table on Detection rules(siem) page is missing accessible discernible text (#205336) (#205629) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text (#205336)](#205336) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T16:24:20Z","message":"fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text (#205336)\n\nCloses: #204483\r\n\r\nRelated to: https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description \r\n\r\nA similar issue was already fixed in\r\nhttps://github.com//pull/188075. To address #204483, we\r\njust need to restore the name from the fetchRulesSnoozeSettings request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor"],"title":"fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text","number":205336,"url":"https://github.com/elastic/kibana/pull/205336","mergeCommit":{"message":"fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text (#205336)\n\nCloses: #204483\r\n\r\nRelated to: https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description \r\n\r\nA similar issue was already fixed in\r\nhttps://github.com//pull/188075. To address #204483, we\r\njust need to restore the name from the fetchRulesSnoozeSettings request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205336","number":205336,"mergeCommit":{"message":"fix: [Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text (#205336)\n\nCloses: #204483\r\n\r\nRelated to: https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description \r\n\r\nA similar issue was already fixed in\r\nhttps://github.com//pull/188075. To address #204483, we\r\njust need to restore the name from the fetchRulesSnoozeSettings request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336) Closes: elastic#204483 Related to: elastic#188075 ## Description A similar issue was already fixed in elastic#188075. To address elastic#204483, we just need to restore the name from the fetchRulesSnoozeSettings request. ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6" /> --------- Co-authored-by: kibanamachine <[email protected]>
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336) Closes: elastic#204483 Related to: elastic#188075 ## Description A similar issue was already fixed in elastic#188075. To address elastic#204483, we just need to restore the name from the fetchRulesSnoozeSettings request. ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6" /> --------- Co-authored-by: kibanamachine <[email protected]>
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336) Closes: elastic#204483 Related to: elastic#188075 ## Description A similar issue was already fixed in elastic#188075. To address elastic#204483, we just need to restore the name from the fetchRulesSnoozeSettings request. ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6" /> --------- Co-authored-by: kibanamachine <[email protected]>
Closes: #204483
Related to: #188075
Description
A similar issue was already fixed in #188075. To address #204483, we just need to restore the name from the fetchRulesSnoozeSettings request.
Screen