-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Add alerts test to serverless (#205524) #205530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viduni94
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Obs AI Assistant
Observability AI Assistant
backport:version
Backport to applied version labels
v8.18.0
labels
Jan 3, 2025
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
neptunian
approved these changes
Jan 3, 2025
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
cc @viduni94 |
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
…astic#205530) Closes elastic#205524 ## Summary Adds the alerts.spec to serverless tests. It's skipped in MKI because of the LLM proxy. There is an open issue for this - elastic#192751 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit f7b9d15)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
…5530) (#205543) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)](#205530) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T21:01:05Z","message":"[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)\n\nCloses https://github.com/elastic/kibana/issues/205524\r\n\r\n## Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in MKI because of\r\nthe LLM proxy. There is an open issue for this -\r\nhttps://github.com//issues/192751\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs AI Assistant","backport:version","v8.18.0"],"title":"[Obs AI Assistant] Add alerts test to serverless (#205524)","number":205530,"url":"https://github.com/elastic/kibana/pull/205530","mergeCommit":{"message":"[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)\n\nCloses https://github.com/elastic/kibana/issues/205524\r\n\r\n## Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in MKI because of\r\nthe LLM proxy. There is an open issue for this -\r\nhttps://github.com//issues/192751\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205530","number":205530,"mergeCommit":{"message":"[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)\n\nCloses https://github.com/elastic/kibana/issues/205524\r\n\r\n## Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in MKI because of\r\nthe LLM proxy. There is an open issue for this -\r\nhttps://github.com//issues/192751\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Obs AI Assistant
Observability AI Assistant
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205524
Summary
Adds the alerts.spec to serverless tests. It's skipped in MKI because of the LLM proxy. There is an open issue for this - #192751
Checklist
release_note:*
label is applied per the guidelines