[8.x] [ResponseOps][Rules]Move uptime rule params to package (#205238) #205725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connected with elastic#195187 - Moved params of duration anomaly rule type to `/response-ops/rule_params/uptime_duration_anomaly/` - Moved params of monitor status rule type to `/response-ops/rule_params/uptime_monitor_status/` - Moved params of TLS rule type to `/response-ops/rule_params/uptime_tls/` - **Did not move anything related to the legacy TLS rule type.** I ran into a similar issue to elastic#205207 for the monitor status rule type. It doesn't block this PR but some follow up work might be needed for `x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`. We will probably decide after the new year. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit c8d46ee)
💚 Build Succeeded
Metrics [docs]
History
|
cnasikas
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation